From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] ATA convert GSI to irq on ia64
Date: Thu, 8 Feb 2007 20:34:53 +0000 [thread overview]
Message-ID: <20070208203453.GA10122@infradead.org> (raw)
In-Reply-To: <20070208122539.d9c24ad9.akpm@linux-foundation.org>
On Thu, Feb 08, 2007 at 12:25:39PM -0800, Andrew Morton wrote:
> On Thu, 8 Feb 2007 19:42:04 +0000
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > On Thu, Feb 08, 2007 at 03:40:22PM +0800, Zhang, Yanmin wrote:
> > > If an ATA drive uses legacy mode, ata driver will choose 14 and 15 as the
> > > fixed irq number. On ia64 platform, such numbers are GSI and should be converted
> > > to irq vector.
> > >
> > > Below patch against kernel 2.6.20 fixes it.
> >
> > These direct arch ifdefs in core aren't acceptable.
>
> For 2.6.21 that's true. But this is a suitable fix for 2.6.20.x, no?
Just putting in an #ifndef and allow to to set it up in asm/ata.h
is almost as trivial and a lot nice conceptually. Then again
what happened to the idea of putting fixes into mainline before
-stable?
next prev parent reply other threads:[~2007-02-08 20:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 7:40 [PATCH] ATA convert GSI to irq on ia64 Zhang, Yanmin
2007-02-08 9:15 ` Luming Yu
2007-02-08 9:17 ` Luming Yu
2007-02-09 1:07 ` Zhang, Yanmin
2007-02-08 19:42 ` Christoph Hellwig
2007-02-08 20:25 ` Andrew Morton
2007-02-08 20:34 ` Christoph Hellwig [this message]
2007-02-08 20:46 ` Andrew Morton
2007-02-09 1:19 ` Jeff Garzik
2007-02-09 3:29 ` Zhang, Yanmin
2007-02-15 23:09 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070208203453.GA10122@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).