From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: sshtylyov@ru.mvista.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] (pata-2.6 fix queue) cmd64x: remove broken SW/MW DMA support
Date: Sat, 10 Feb 2007 01:11:55 +0100 [thread overview]
Message-ID: <200702100111.55257.bzolnier@gmail.com> (raw)
In-Reply-To: <200702080858.l188wjmG008432@harpo.it.uu.se>
On Thursday 08 February 2007 09:58, Mikael Pettersson wrote:
> On Thu, 8 Feb 2007 00:00:32 +0300, Sergei Shtylyov wrote:
> >Remove the bogus code pretending to set SW/MW DMA timings -- I wonder whether
> >its author really thought that he could achieve that wrtiting to BMIDE status
> >registers? Stop fiddling with the DMA capable bits in the speedproc() -- they
> >do not enable DMA, and are properly dealt with by the dma_host_{on,off} methods;
> >also, get rid of the duplicate reads/writes of UDIDETCRx registers, and do some
> >coding style and whitespace changes while at it...
> >
> >Unfortunately, fixing the SW/MW DMA support would requre a major driver rewrite
> >along with some more fixing, so I'm putting it off...
> >
> >Warning: this has been compile-tested only.
>
> Worked fine on my SPARC Ultra5.
thanks, applied
next prev parent reply other threads:[~2007-02-10 0:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 8:58 [PATCH] (pata-2.6 fix queue) cmd64x: remove broken SW/MW DMA support Mikael Pettersson
2007-02-10 0:11 ` Bartlomiej Zolnierkiewicz [this message]
2007-02-16 10:01 ` Mikael Pettersson
2007-02-16 13:11 ` Sergei Shtylyov
2007-02-16 13:39 ` Sergei Shtylyov
2007-02-16 14:42 ` Bartlomiej Zolnierkiewicz
2007-02-16 15:06 ` Sergei Shtylyov
2007-02-16 14:37 ` Bartlomiej Zolnierkiewicz
2007-02-16 15:00 ` Sergei Shtylyov
2007-02-16 15:29 ` Bartlomiej Zolnierkiewicz
2007-02-16 15:34 ` Sergei Shtylyov
2007-02-16 16:23 ` Bartlomiej Zolnierkiewicz
-- strict thread matches above, loose matches on Subject: below --
2007-02-07 21:00 Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702100111.55257.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).