* [patch 10/21] ide: fix drive side 80c cable check
[not found] ` <20070221013619.GA30227@kroah.com>
@ 2007-02-21 1:37 ` Greg KH
2007-02-21 1:37 ` [patch 11/21] pata_amd: fix an obvious bug in cable detection Greg KH
1 sibling, 0 replies; 2+ messages in thread
From: Greg KH @ 2007-02-21 1:37 UTC (permalink / raw)
To: linux-kernel, stable, Alan
Cc: Justin Forbes, Zwane Mwaikambo, Theodore Ts'o, Randy Dunlap,
Dave Jones, Chuck Wolber, Chris Wedgwood, Michael Krufky,
torvalds, akpm, linux-ide, bzolnier, Tejun Heo
[-- Attachment #1: ide-fix-drive-side-80c-cable-check.patch --]
[-- Type: text/plain, Size: 895 bytes --]
-stable review patch. If anyone has any objections, please let us know.
------------------
eighty_ninty_three() had word 93 validitity check but not the 80c bit
test itself (bit 12). This increases the chance of incorrect wire
detection especially because host side cable detection is often
unreliable and we sometimes soley depend on drive side cable
detection. Fix it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Alan <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/ide/ide-iops.c | 2 ++
1 file changed, 2 insertions(+)
--- linux-2.6.19.4.orig/drivers/ide/ide-iops.c
+++ linux-2.6.19.4/drivers/ide/ide-iops.c
@@ -607,6 +607,8 @@ u8 eighty_ninty_three (ide_drive_t *driv
if(!(drive->id->hw_config & 0x4000))
return 0;
#endif /* CONFIG_IDEDMA_IVB */
+ if (!(drive->id->hw_config & 0x2000))
+ return 0;
return 1;
}
--
^ permalink raw reply [flat|nested] 2+ messages in thread* [patch 11/21] pata_amd: fix an obvious bug in cable detection
[not found] ` <20070221013619.GA30227@kroah.com>
2007-02-21 1:37 ` [patch 10/21] ide: fix drive side 80c cable check Greg KH
@ 2007-02-21 1:37 ` Greg KH
1 sibling, 0 replies; 2+ messages in thread
From: Greg KH @ 2007-02-21 1:37 UTC (permalink / raw)
To: linux-kernel, stable, Jeff Garzik, Alan Cox, linux-ide
Cc: Justin Forbes, Zwane Mwaikambo, Theodore Ts'o, Randy Dunlap,
Dave Jones, Chuck Wolber, Chris Wedgwood, Michael Krufky,
torvalds, akpm, Tejun Heo
[-- Attachment #1: pata_amd-fix-an-obvious-bug-in-cable-detection.patch --]
[-- Type: text/plain, Size: 1087 bytes --]
-stable review patch. If anyone has any objections, please let us know.
------------------
80c test mask is at bits 18 and 19 of EIDE Controller Configuration
not 22 and 23. Fix it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
drivers/ata/pata_amd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.19.4.orig/drivers/ata/pata_amd.c
+++ linux-2.6.19.4/drivers/ata/pata_amd.c
@@ -128,7 +128,7 @@ static void timing_setup(struct ata_port
static int amd_pre_reset(struct ata_port *ap)
{
- static const u32 bitmask[2] = {0x03, 0xC0};
+ static const u32 bitmask[2] = {0x03, 0x0C};
static const struct pci_bits amd_enable_bits[] = {
{ 0x40, 1, 0x02, 0x02 },
{ 0x40, 1, 0x01, 0x01 }
@@ -247,7 +247,7 @@ static void amd133_set_dmamode(struct at
*/
static int nv_pre_reset(struct ata_port *ap) {
- static const u8 bitmask[2] = {0x03, 0xC0};
+ static const u8 bitmask[2] = {0x03, 0x0C};
static const struct pci_bits nv_enable_bits[] = {
{ 0x50, 1, 0x02, 0x02 },
{ 0x50, 1, 0x01, 0x01 }
--
^ permalink raw reply [flat|nested] 2+ messages in thread