From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH 2.6.21-rc2] pata_legacy: fix io/irq mismatch Date: Sat, 3 Mar 2007 17:59:59 -0500 Message-ID: <20070303225959.GA29420@devserv.devel.redhat.com> References: <200703031957.l23JviQQ005254@harpo.it.uu.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([66.187.233.31]:48318 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933154AbXCCXAF (ORCPT ); Sat, 3 Mar 2007 18:00:05 -0500 Content-Disposition: inline In-Reply-To: <200703031957.l23JviQQ005254@harpo.it.uu.se> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mikael Pettersson Cc: alan@redhat.com, linux-ide@vger.kernel.org On Sat, Mar 03, 2007 at 08:57:44PM +0100, Mikael Pettersson wrote: > pata_legacy fails to detect the disk on my old ISA/VLB 486: > it starts to probe io=0x1f0 ctr=0x3f6 irq=15, complains > loudly about IDENTIFYs timing out, and finally fails. > (Sorry I couldn't capture the kernel's boot messages.) > > It turns out that the driver's mapping from io to irq in > legacy_irq[] is wrong: index 0 for io=0x1f0 has irq=15 but > should have irq=14, and index 1 for io=0x170 has irq=14 but > should have irq=15. This is confirmed by a comparison with > include/asm-i386/ide.h:ide_default_irq(). > > This patch swaps the first two elements in legacy_irq[], > which makes pata_legacy work on my 486. > > Signed-off-by: Mikael Pettersson Acked-by: Alan Cox