From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2.6.22] remove Intel combined mode quirk Date: Fri, 9 Mar 2007 21:36:28 +0100 Message-ID: <200703092136.28535.bzolnier@gmail.com> References: <20070309160127.GA10226@havoc.gtf.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ug-out-1314.google.com ([66.249.92.175]:5234 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933075AbXCIU3d (ORCPT ); Fri, 9 Mar 2007 15:29:33 -0500 Received: by ug-out-1314.google.com with SMTP id 44so1463073uga for ; Fri, 09 Mar 2007 12:29:31 -0800 (PST) In-Reply-To: <20070309160127.GA10226@havoc.gtf.org> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: linux-ide@vger.kernel.org, LKML , Linus Torvalds On Friday 09 March 2007, Jeff Garzik wrote: > > Discussed for 2.6.21, but pushed back because the current SATA code > had enough fun stuff to debug already. Thus, just queued the following > for 2.6.22 in libata-dev.git#upstream. > > The nasty ____request_resource hack is finally gone. > > In practical terms, this usually means that some combined mode users > will have their SATA devices driven by the old-IDE driver rather than > libata (because old-IDE is often non-modular, and thus probes first). > > But really, these same users will IMO cheer the removal of the > performance-killing split-driver configuration, so its a net win. > And the code is smaller and more clean, with one less special case > hack. > > libata/IDE: remove combined mode quirk > > Both old-IDE and libata should be able handle all controllers and > devices found using normal resource reservation methods. > > This eliminates the awful, low-performing split-driver configuration > where old-IDE drove the PATA portion of a PCI device, in PIO-only mode, > and libata drove the SATA portion of the /same/ PCI device, in DMA mode. > Typically vendors would ship SATA hard drive / PATA optical > configuration, which would lend itself to slow (PIO-only) CD-ROM > performance. > > For Intel users running in combined mode, it is now wholly dependent on > your driver choice (potentially link order, if you compile both drivers > in) whether old-IDE or libata will drive your hardware. > > In either case, you will get full performance from both SATA and PATA > ports now, without having to pass a kernel command line parameter. > > Signed-off-by: Jeff Garzik Acked-by: Bartlomiej Zolnierkiewicz Thanks for fixing this. Bart