From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: gregkh@suse.de, Jeff Garzik <jeff@garzik.org>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
michal.k.k.piotrowski@gmail.com, linux-ide@vger.kernel.org,
tglx@linutronix.de, shemminger@linux-foundation.org,
mlord@pobox.com, linux-pm@lists.osdl.org
Subject: Re: [PATCH/RFC] PCI prepare/activate instead of enable to avoid IRQ storm and rogue DMA access
Date: Wed, 14 Mar 2007 21:56:06 +0000 [thread overview]
Message-ID: <20070314215605.GA7194@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20070314152302.GB15600@htj.dyndns.org>
On Thu, Mar 15, 2007 at 12:23:02AM +0900, Tejun Heo wrote:
> The problem is that a PCI device can be in any arbitrary when it gets
> enabled and the device has to be enabled for its driver to
> initialize/reset it. The most common case this causes headache is as
> follows.
>
> Let's assume there's a device which shares its INTX IRQ line with
> another device and the other one is already initialized.
pci_enable_device() doesn't deal with this; in most PCI setups I've
seen, there is no control at PCI level over whether a device generates
an interrupt on the bus. Certainly the memory and io command enables
have no effect on the ability of the device to cause an interrupt.
In most cases, only the driver of the device knows how to disable
interrupts on any particular device.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-03-14 21:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 15:23 [PATCH/RFC] PCI prepare/activate instead of enable to avoid IRQ storm and rogue DMA access Tejun Heo
2007-03-14 17:04 ` Alan Stern
2007-03-14 17:07 ` Stephen Hemminger
2007-03-15 2:37 ` Tejun Heo
2007-03-15 6:45 ` Grant Grundler
2007-03-16 21:21 ` Stephen Hemminger
2007-03-14 21:46 ` Andi Kleen
2007-03-15 2:39 ` Tejun Heo
2007-03-15 10:17 ` Andi Kleen
2007-03-15 11:41 ` Vivek Goyal
2007-03-14 21:56 ` Russell King [this message]
2007-03-14 22:34 ` Jeff Garzik
2007-03-14 22:58 ` Russell King
2007-03-14 23:16 ` Jeff Garzik
2007-03-15 5:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070314215605.GA7194@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-pm@lists.osdl.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=mlord@pobox.com \
--cc=shemminger@linux-foundation.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).