From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@SteelEye.com>,
djwong@us.ibm.com, hmh@hmh.eng.br
Subject: [PATCH 1/3] sd: fix return value of sd_sync_cache()
Date: Wed, 21 Mar 2007 00:07:18 +0900 [thread overview]
Message-ID: <20070320150718.GF6152@htj.dyndns.org> (raw)
sd_sync_cache() should return -errno on error, fix it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
drivers/scsi/sd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: work/drivers/scsi/sd.c
===================================================================
--- work.orig/drivers/scsi/sd.c
+++ work/drivers/scsi/sd.c
@@ -817,7 +817,9 @@ static int sd_sync_cache(struct scsi_dev
scsi_print_sense_hdr("sd", &sshdr);
}
- return res;
+ if (res)
+ return -EIO;
+ return 0;
}
static int sd_issue_flush(struct device *dev, sector_t *error_sector)
next reply other threads:[~2007-03-20 15:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 15:07 Tejun Heo [this message]
2007-03-20 15:13 ` [PATCH 2/3] sd: implement START/STOP management Tejun Heo
2007-03-20 15:25 ` [PATCH 3/4] libata: reimplement suspend/resume support using sdev->manage_start_stop Tejun Heo
2007-03-20 15:29 ` Christoph Hellwig
2007-03-21 7:05 ` [PATCH scsi-misc-2.6] SCSI: kill sht->suspend/resume Tejun Heo
2007-03-21 14:19 ` Christoph Hellwig
2007-03-21 15:16 ` James Bottomley
2007-05-14 15:52 ` Tejun Heo
2007-03-20 15:55 ` [PATCH 4/4] libata: implement libata.spindown_compat Tejun Heo
2007-04-17 14:45 ` Jeff Garzik
2007-04-17 15:01 ` James Bottomley
2007-04-17 15:20 ` Jeff Garzik
2007-04-17 15:26 ` James Bottomley
2007-04-17 17:09 ` Tejun Heo
2007-04-17 17:33 ` James Bottomley
2007-03-20 16:39 ` [PATCH 3/4] libata: reimplement suspend/resume support using sdev->manage_start_stop Alan Cox
2007-03-20 16:15 ` Oliver Neukum
2007-03-20 16:58 ` [PATCH 2/3] sd: implement START/STOP management James Bottomley
2007-03-20 17:08 ` Tejun Heo
2007-03-20 17:26 ` James Bottomley
2007-03-21 3:42 ` Tejun Heo
2007-03-20 17:58 ` Douglas Gilbert
2007-03-20 18:41 ` James Bottomley
2007-03-21 2:35 ` Tejun Heo
2007-03-22 10:21 ` Vladislav Bolkhovitin
2007-03-22 12:29 ` Henrique de Moraes Holschuh
2007-03-22 15:14 ` Vladislav Bolkhovitin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070320150718.GF6152@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=James.Bottomley@SteelEye.com \
--cc=djwong@us.ibm.com \
--cc=hmh@hmh.eng.br \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).