From: Matthew Garrett <mjg59@srcf.ucam.org>
To: linux-ide@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: kristen.c.accardi@intel.com
Subject: Re: [PATCH] Add _GTM and _STM support to libata
Date: Mon, 26 Mar 2007 04:39:44 +0100 [thread overview]
Message-ID: <20070326033944.GA13395@srcf.ucam.org> (raw)
In-Reply-To: <20070326032222.GA13113@srcf.ucam.org>
> + printk(KERN_ERR
> + "%s: unexpected _GTM length (0x%x)[should be 0x%zx] or \
> +"
> + "addr (0x%p)\n",
> + __FUNCTION__, out_obj->buffer.length,
> + sizeof(struct GTM_buffer), out_obj->buffer.pointer);
Yeah, erm.
> + * _STM requires Identify Drive data, which has to passed as an argument.
> + * Unfortunately hd_driveid is a mangled version which we can't readily
> + * use; hence we'll get the information afresh.
And clearly this doesn't actually match reality either. I'll send a
tidied up patch when I've actually slept.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2007-03-26 3:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 3:22 [PATCH] Add _GTM and _STM support to libata Matthew Garrett
2007-03-26 3:39 ` Matthew Garrett [this message]
2007-03-26 10:58 ` Alan Cox
2007-03-26 20:15 ` Matthew Garrett
2007-03-26 21:40 ` Alan Cox
2007-03-26 21:48 ` Matthew Garrett
2007-03-26 23:39 ` Alan Cox
2007-03-26 22:44 ` Matthew Garrett
2007-03-26 11:02 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070326033944.GA13395@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).