From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
kyle@canonical.com
Subject: Re: HPA patches
Date: Wed, 28 Mar 2007 22:28:29 +0100 [thread overview]
Message-ID: <20070328212829.GA14263@srcf.ucam.org> (raw)
In-Reply-To: <20070328225431.69d0a3cc@the-village.bc.nu>
On Wed, Mar 28, 2007 at 10:54:31PM +0100, Alan Cox wrote:
> I wonder if the firmware is dying when we ask the disk to go zero sized
> rather than erroring politely. I'm not sure hth HPA sectors can come back
> as zero but we can be fairly sure 0 means "no HPA" in this case I guess ?
No, it seems to be looking at 0 because ata_read_native_max_address_ext
returns 0 in the error case - the error that ata_exec_internal generates
seems to be AC_ERR_HSM. Since 0 isn't > the size reported, we'll never
try to resize it anyway, judging by ata_hpa_resize - that is, it seems
to be the ata_read_native_max_address_ext call that breaks it.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2007-03-28 21:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 19:13 HPA patches Alan Cox
2007-03-23 18:24 ` Randy Dunlap
2007-03-23 20:08 ` Alan Cox
2007-03-23 19:22 ` David Miller
2007-03-23 21:51 ` Alan Cox
2007-03-23 20:03 ` Randy Dunlap
2007-03-23 21:47 ` Alan Cox
2007-03-23 22:47 ` Chuck Ebbert
2007-04-13 3:16 ` Kyle McMartin
2007-04-13 10:56 ` Alan Cox
2007-03-23 20:56 ` Matthew Garrett
2007-03-27 5:00 ` Jeff Garzik
2007-03-26 20:45 ` Kyle McMartin
2007-03-28 0:08 ` Matthew Garrett
2007-03-28 0:16 ` Matthew Garrett
2007-03-28 1:16 ` ata_piix can't drive Mac hardware properly Matthew Garrett
2007-03-28 4:07 ` Matthew Garrett
2007-03-28 9:57 ` HPA patches Alan Cox
2007-03-28 20:08 ` Matthew Garrett
2007-03-28 21:54 ` Alan Cox
2007-03-28 21:28 ` Matthew Garrett [this message]
2007-03-28 21:30 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070328212829.GA14263@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kyle@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).