From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2] Add suspend/resume for HPET Date: Sat, 31 Mar 2007 09:41:52 -0700 Message-ID: <20070331164152.GA13976@suse.de> References: <460BBD1B.4040308@ru.mvista.com> <200703291531.18253.maximlevitsky@gmail.com> <200703291546.48996.maximlevitsky@gmail.com> <1175356272.28263.27.camel@localhost.localdomain> <1175358800.28263.36.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns.suse.de ([195.135.220.2]:40062 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752928AbXCaQmB (ORCPT ); Sat, 31 Mar 2007 12:42:01 -0400 Content-Disposition: inline In-Reply-To: <1175358800.28263.36.camel@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Thomas Gleixner Cc: Linus Torvalds , Maxim Levitsky , Sergei Shtylyov , Ingo Molnar , Jeff Chua , Adrian Bunk , Andrew Morton , Linux Kernel Mailing List , "Eric W. Biederman" , "Rafael J. Wysocki" , pavel@suse.cz, linux-pm@lists.osdl.org, linux-pci@atrey.karlin.mff.cuni.cz, Jens Axboe , Len Brown , linux-acpi@vger.kernel.org, jgarzik@pobox.com, linux-ide@vger.kernel.org, "Michael S. Tsirkin" On Sat, Mar 31, 2007 at 06:33:20PM +0200, Thomas Gleixner wrote: > On Sat, 2007-03-31 at 09:09 -0700, Linus Torvalds wrote: > > > > On Sat, 31 Mar 2007, Thomas Gleixner wrote: > > > > > > While I agree in principle with the patch, I'm a bit uncomfortable. The > > > sys device suspend / resume ordering is not guaranteed and relies on the > > > registering order. > > > > Well, this is why we probably should try to get away from the "system > > device" issue, exactly because system devices are totally outside the > > normal ordering and only have a random linear order. > > > > If the clocksources were actually in the device tree, you'd get all the > > normal guarantees about hierarchical ordering.. > > Right, but clock - sources/events need to be extremly late suspended and > early resumed. How can we ensure this ? Put it at the top of the device tree. thanks, greg k-h