From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Stuart_Hayes@dell.com
Cc: alan@lxorguk.ukuu.org.uk, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ugly messages trying to open CD drive with no media present
Date: Fri, 6 Apr 2007 23:05:56 +0200 [thread overview]
Message-ID: <200704062305.56964.bzolnier@gmail.com> (raw)
In-Reply-To: <DFEF91B22ED07447AB6AA4B237F913F9524A30@ausx3mpc125.aus.amer.dell.com>
On Monday 02 April 2007, Stuart_Hayes@dell.com wrote:
>
> I get the following error messages when trying to open a CD device
> (specifically, the Teac CD-ROM CD-224E) that has no media present:
>
> hda: packet command error: status=0x51 { DriveReady SeekComplete Error }
> hda: packet command error: error=0x54 { AbortedCommand
> LastFailedSense=0x05 }
> ide: failed opcode was: unknown
>
> This happens when a "start stop unit" command (0x1b 0 0 0 3 0 0 0 0 0)
> is sent to the drive to try to close the CD-ROM tray, but this drive
> doesn't have that capability (it's a slim portable-type CD-ROM), so it
> reports sense key 5 (illegal request) with asc/ascq 24/0. This is
> exactly how SFF8090i says it should respond.
>
> But ide-cd.c (in cdrom_decode_status() ) just sees sense key 5 and spews
> out an error. It then goes on to request sense data, and
> cdrom_log_sense() understands this error and doesn't log it.
>
> The patch, for kernel 2.6.20.4, suppresses this error message.
>
> Signed-off-by: Stuart Hayes <stuart_hayes@dell.com>
Alan, any opinions on this one (this is ide-cd specific patch)?
I applied it to my tree for now and would like to send it to Linus
soon so the patch still makes it into 2.6.21...
Bart
prev parent reply other threads:[~2007-04-06 21:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-02 19:51 [PATCH] ugly messages trying to open CD drive with no media present Stuart_Hayes
2007-04-06 21:05 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704062305.56964.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=Stuart_Hayes@dell.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).