Re: [PATCH] pasemi: electra IDE/pata_platform glue

[olof@lixom.net (Olof Johansson)]

On Sun, May 13, 2007 at 12:20:10PM +1000, Benjamin Herrenschmidt wrote:
>
> Then, the plans I have in mind for the future of that stuff are around
> the idea of registering "constructors" based on bus matches and device
> matches respectively.
> 
> The kernel will then walk the whole OF device-tree at boot, and will
> instanciate devices using those constructors, passing them the struct
> device of whatever was the parent.
> 
> Thus we could easily have platforms registers constructors for specific
> devices that build a platform device off an OF node.

Great. That should fit perfectly with the glue I have now, it'll turn
into the constructor instead.

I honestly don't see what the benefit is of this recent obsession
with creating of_platform devices for every new device that's not
PCI, especially when there's an already well-fitting driver in the
traditional platform model. It's not like the code to link the two is
large and complex.

Also, in this particular case, the bindings are not standardized, and
there's a good chance that whatever new platform uses a similar device
will need to do something slightly different.


-Olof