* RE: [PATCH]add the IDE device ID for ATI SB700
2007-05-15 22:37 ` [PATCH]add the IDE device ID for ATI SB700 Bartlomiej Zolnierkiewicz
@ 2007-05-16 3:38 ` Henry Su
2007-05-16 7:32 ` Henry Su
2007-05-23 9:26 ` Henry Su
2 siblings, 0 replies; 4+ messages in thread
From: Henry Su @ 2007-05-16 3:38 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, gmail_ati; +Cc: linux-ide
hi Bart,
Thanks for your kindly reply, it's seems that something wrong with the MS outlook,
the IXP700 device ID is defined to /linux/pci_ids.h in another patch,I will resend the
complete patch.
BRS,
Henry
-----Original Message-----
From: Bartlomiej Zolnierkiewicz [mailto:bzolnier@gmail.com]
Sent: Wednesday, May 16, 2007 6:37 AM
To: gmail_ati
Cc: Henry Su; linux-ide@vger.kernel.org
Subject: Re: [PATCH]add the IDE device ID for ATI SB700
Hi,
On Monday 14 May 2007, gmail_ati wrote:
> From: henry.su.ati@gmail.com
> add the IDE device ids to atiixp_pci_tbl struct in atiixp.c for ATI SB700.
> Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
This patch is somehow missing the chunk adding PCI_DEVICE_ID_ATI_IXP700_IDE
define to <linux/pci_ids.h> and thus makes atiixp.c fail to compile.
Please resend the complete patch.
PS your mailer seems to encode patches in some strange way (whitespaces are
mangled and saved email contained MIME encoded text instead of plain-text) so
I had to apply this change by hand. Not really a problem for this particular
patch ;) but definitively something needing fixing.
Thanks,
Bart
> -----------------------------------------------------
> diff -Nur linux-2.6.21.1.org/drivers/ide/pci/atiixp.c linux-2.6.21.1/drivers/ide/pci/atiixp.c
> --- linux-2.6.21.1.org/drivers/ide/pci/atiixp.c 2007-05-13 04:47:25.000000000 +0800
> +++ linux-2.6.21.1/drivers/ide/pci/atiixp.c 2007-05-13 05:14:08.000000000 +0800
> @@ -353,6 +353,7 @@
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH]add the IDE device ID for ATI SB700
2007-05-15 22:37 ` [PATCH]add the IDE device ID for ATI SB700 Bartlomiej Zolnierkiewicz
2007-05-16 3:38 ` Henry Su
@ 2007-05-16 7:32 ` Henry Su
2007-05-23 9:26 ` Henry Su
2 siblings, 0 replies; 4+ messages in thread
From: Henry Su @ 2007-05-16 7:32 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, gmail_ati; +Cc: linux-ide
[-- Attachment #1: Type: text/plain, Size: 2344 bytes --]
hi Bart,
I resend 4 patches for adding the device IDs(SMBus,IDE and SATA) of ATI SB700, the attached file is the complete patch,
could you please apply it if there are something wrong with the mailer?
Many Thanks
Henry
-----Original Message-----
From: Bartlomiej Zolnierkiewicz [mailto:bzolnier@gmail.com]
Sent: Wednesday, May 16, 2007 6:37 AM
To: gmail_ati
Cc: Henry Su; linux-ide@vger.kernel.org
Subject: Re: [PATCH]add the IDE device ID for ATI SB700
Hi,
On Monday 14 May 2007, gmail_ati wrote:
> From: henry.su.ati@gmail.com
> add the IDE device ids to atiixp_pci_tbl struct in atiixp.c for ATI SB700.
> Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
This patch is somehow missing the chunk adding PCI_DEVICE_ID_ATI_IXP700_IDE
define to <linux/pci_ids.h> and thus makes atiixp.c fail to compile.
Please resend the complete patch.
PS your mailer seems to encode patches in some strange way (whitespaces are
mangled and saved email contained MIME encoded text instead of plain-text) so
I had to apply this change by hand. Not really a problem for this particular
patch ;) but definitively something needing fixing.
Thanks,
Bart
> -----------------------------------------------------
> diff -Nur linux-2.6.21.1.org/drivers/ide/pci/atiixp.c linux-2.6.21.1/drivers/ide/pci/atiixp.c
> --- linux-2.6.21.1.org/drivers/ide/pci/atiixp.c 2007-05-13 04:47:25.000000000 +0800
> +++ linux-2.6.21.1/drivers/ide/pci/atiixp.c 2007-05-13 05:14:08.000000000 +0800
> @@ -353,6 +353,7 @@
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
[-- Attachment #2: SB700_Patches --]
[-- Type: application/octet-stream, Size: 3883 bytes --]
diff -Nur linux-2.6.21.1.orig/include/linux/pci_ids.h linux-2.6.21.1/include/linux/pci_ids.h
--- linux-2.6.21.1.orig/include/linux/pci_ids.h 2007-05-16 13:28:54.405386000 +0800
+++ linux-2.6.21.1/include/linux/pci_ids.h 2007-05-16 13:45:29.936636000 +0800
@@ -371,6 +371,9 @@
#define PCI_DEVICE_ID_ATI_IXP600_SRAID 0x4381
#define PCI_DEVICE_ID_ATI_IXP600_SMBUS 0x4385
#define PCI_DEVICE_ID_ATI_IXP600_IDE 0x438c
+#define PCI_DEVICE_ID_ATI_IXP700_SATA 0x4390
+#define PCI_DEVICE_ID_ATI_IXP700_SMBUS 0x4395
+#define PCI_DEVICE_ID_ATI_IXP700_IDE 0x439c
#define PCI_VENDOR_ID_VLSI 0x1004
#define PCI_DEVICE_ID_VLSI_82C592 0x0005
diff -Nur linux-2.6.21.1.orig/drivers/i2c/busses/i2c-piix4.c linux-2.6.21.1/drivers/i2c/busses/i2c-piix4.c
--- linux-2.6.21.1.orig/drivers/i2c/busses/i2c-piix4.c 2007-05-16 13:27:53.014761000 +0800
+++ linux-2.6.21.1/drivers/i2c/busses/i2c-piix4.c 2007-05-16 13:40:21.546011000 +0800
@@ -23,7 +23,7 @@
Supports:
Intel PIIX4, 440MX
Serverworks OSB4, CSB5, CSB6, HT-1000
- ATI IXP200, IXP300, IXP400, SB600
+ ATI IXP200, IXP300, IXP400, SB600, SB700
SMSC Victory66
Note: we assume there can only be one device, with one SMBus interface.
@@ -399,6 +399,8 @@
.driver_data = 0 },
{ PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_SMBUS),
.driver_data = 0 },
+ { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_SMBUS),
+ .driver_data = 0 },
{ PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_OSB4),
.driver_data = 0 },
{ PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5),
diff -Nur linux-2.6.21.1.orig/drivers/ata/pata_atiixp.c linux-2.6.21.1/drivers/ata/pata_atiixp.c
--- linux-2.6.21.1.orig/drivers/ata/pata_atiixp.c 2007-05-16 13:27:49.764761000 +0800
+++ linux-2.6.21.1/drivers/ata/pata_atiixp.c 2007-05-16 13:37:47.014761000 +0800
@@ -283,6 +283,7 @@
{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP300_IDE), },
{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP400_IDE), },
{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP600_IDE), },
+ { PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP700_IDE), },
{ },
};
diff -Nur linux-2.6.21.1.orig/drivers/ata/ahci.c linux-2.6.21.1/drivers/ata/ahci.c
--- linux-2.6.21.1.orig/drivers/ata/ahci.c 2007-05-16 13:27:49.717886000 +0800
+++ linux-2.6.21.1/drivers/ata/ahci.c 2007-05-16 13:42:40.155386000 +0800
@@ -415,6 +415,7 @@
/* ATI */
{ PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 non-raid */
{ PCI_VDEVICE(ATI, 0x4381), board_ahci }, /* ATI SB600 raid */
+ { PCI_VDEVICE(ATI, 0x4390), board_ahci_sb600 }, /* ATI SB700 non-raid */
/* VIA */
{ PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251 */
diff -Nur linux-2.6.21.1.orig/drivers/ide/pci/atiixp.c linux-2.6.21.1/drivers/ide/pci/atiixp.c
--- linux-2.6.21.1.orig/drivers/ide/pci/atiixp.c 2007-05-16 13:27:53.671011000 +0800
+++ linux-2.6.21.1/drivers/ide/pci/atiixp.c 2007-05-16 13:43:51.952261000 +0800
@@ -353,6 +353,7 @@
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
+ { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
{ 0, },
};
MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
diff -Nur linux-2.6.21.1.orig/drivers/pci/quirks.c linux-2.6.21.1/drivers/pci/quirks.c
--- linux-2.6.21.1.orig/drivers/pci/quirks.c 2007-05-16 13:28:09.702261000 +0800
+++ linux-2.6.21.1/drivers/pci/quirks.c 2007-05-16 13:41:26.155386000 +0800
@@ -875,6 +875,7 @@
}
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_SATA, quirk_sb600_sata);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_sb600_sata);
/*
* Serverworks CSB5 IDE does not fully support native mode
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH]add the IDE device ID for ATI SB700
2007-05-15 22:37 ` [PATCH]add the IDE device ID for ATI SB700 Bartlomiej Zolnierkiewicz
2007-05-16 3:38 ` Henry Su
2007-05-16 7:32 ` Henry Su
@ 2007-05-23 9:26 ` Henry Su
2 siblings, 0 replies; 4+ messages in thread
From: Henry Su @ 2007-05-23 9:26 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, gmail_ati; +Cc: linux-ide
Hi Bart,
I have resent four patches for the ATI SB700 chipset, could you please help me check if these patches are applied?
I list all patches as following, Thanks for your help!
BRs,
Henry
[PATCH 1/4] add the SMBus device ID for ATI SB700
From: henry.su@amd.com
add the SMBUS device id for ATI SB700.
Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
-----------------------------------------------------
diff -Nur linux-2.6.21.1.orig/include/linux/pci_ids.h linux-2.6.21.1/include/linux/pci_ids.h
--- linux-2.6.21.1.orig/include/linux/pci_ids.h 2007-05-16 13:28:54.405386000 +0800
+++ linux-2.6.21.1/include/linux/pci_ids.h 2007-05-16 13:45:29.936636000 +0800
@@ -371,6 +371,9 @@
#define PCI_DEVICE_ID_ATI_IXP600_SRAID 0x4381
#define PCI_DEVICE_ID_ATI_IXP600_SMBUS 0x4385
#define PCI_DEVICE_ID_ATI_IXP600_IDE 0x438c
+#define PCI_DEVICE_ID_ATI_IXP700_SATA 0x4390
+#define PCI_DEVICE_ID_ATI_IXP700_SMBUS 0x4395
+#define PCI_DEVICE_ID_ATI_IXP700_IDE 0x439c
#define PCI_VENDOR_ID_VLSI 0x1004
#define PCI_DEVICE_ID_VLSI_82C592 0x0005
diff -Nur linux-2.6.21.1.orig/drivers/i2c/busses/i2c-piix4.c linux-2.6.21.1/drivers/i2c/busses/i2c-piix4.c
--- linux-2.6.21.1.orig/drivers/i2c/busses/i2c-piix4.c 2007-05-16 13:27:53.014761000 +0800
+++ linux-2.6.21.1/drivers/i2c/busses/i2c-piix4.c 2007-05-16 13:40:21.546011000 +0800
@@ -23,7 +23,7 @@
Supports:
Intel PIIX4, 440MX
Serverworks OSB4, CSB5, CSB6, HT-1000
- ATI IXP200, IXP300, IXP400, SB600
+ ATI IXP200, IXP300, IXP400, SB600, SB700
SMSC Victory66
Note: we assume there can only be one device, with one SMBus interface.
@@ -399,6 +399,8 @@
.driver_data = 0 },
{ PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_SMBUS),
.driver_data = 0 },
+ { PCI_DEVICE(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_SMBUS),
+ .driver_data = 0 },
{ PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_OSB4),
.driver_data = 0 },
{ PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_CSB5),
[PATCH 2/4] add the IDE and SATA device IDs for ATI SB700.
From: henry.su@amd.com
add the IDE and SATA device ids for ATI SB700.
Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
-----------------------------------------------------
diff -Nur linux-2.6.21.1.orig/include/linux/pci_ids.h linux-2.6.21.1/include/linux/pci_ids.h
--- linux-2.6.21.1.orig/include/linux/pci_ids.h 2007-05-16 13:28:54.405386000 +0800
+++ linux-2.6.21.1/include/linux/pci_ids.h 2007-05-16 13:45:29.936636000 +0800
@@ -371,6 +371,9 @@
#define PCI_DEVICE_ID_ATI_IXP600_SRAID 0x4381
#define PCI_DEVICE_ID_ATI_IXP600_SMBUS 0x4385
#define PCI_DEVICE_ID_ATI_IXP600_IDE 0x438c
+#define PCI_DEVICE_ID_ATI_IXP700_SATA 0x4390
+#define PCI_DEVICE_ID_ATI_IXP700_SMBUS 0x4395
+#define PCI_DEVICE_ID_ATI_IXP700_IDE 0x439c
#define PCI_VENDOR_ID_VLSI 0x1004
#define PCI_DEVICE_ID_VLSI_82C592 0x0005
diff -Nur linux-2.6.21.1.orig/drivers/ata/pata_atiixp.c linux-2.6.21.1/drivers/ata/pata_atiixp.c
--- linux-2.6.21.1.orig/drivers/ata/pata_atiixp.c 2007-05-16 13:27:49.764761000 +0800
+++ linux-2.6.21.1/drivers/ata/pata_atiixp.c 2007-05-16 13:37:47.014761000 +0800
@@ -283,6 +283,7 @@
{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP300_IDE), },
{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP400_IDE), },
{ PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP600_IDE), },
+ { PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP700_IDE), },
{ },
};
diff -Nur linux-2.6.21.1.orig/drivers/ata/ahci.c linux-2.6.21.1/drivers/ata/ahci.c
--- linux-2.6.21.1.orig/drivers/ata/ahci.c 2007-05-16 13:27:49.717886000 +0800
+++ linux-2.6.21.1/drivers/ata/ahci.c 2007-05-16 13:42:40.155386000 +0800
@@ -415,6 +415,7 @@
/* ATI */
{ PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 non-raid */
{ PCI_VDEVICE(ATI, 0x4381), board_ahci }, /* ATI SB600 raid */
+ { PCI_VDEVICE(ATI, 0x4390), board_ahci_sb600 }, /* ATI SB700 non-raid */
/* VIA */
{ PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251 */
[PATCH 3/4]add the IDE device ID for ATI SB700
From: henry.su@amd.com
add the IDE device ids to atiixp_pci_tbl struct in atiixp.c for ATI SB700.
Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
-----------------------------------------------------
diff -Nur linux-2.6.21.1.orig/include/linux/pci_ids.h linux-2.6.21.1/include/linux/pci_ids.h
--- linux-2.6.21.1.orig/include/linux/pci_ids.h 2007-05-16 13:28:54.405386000 +0800
+++ linux-2.6.21.1/include/linux/pci_ids.h 2007-05-16 13:45:29.936636000 +0800
@@ -371,6 +371,9 @@
#define PCI_DEVICE_ID_ATI_IXP600_SRAID 0x4381
#define PCI_DEVICE_ID_ATI_IXP600_SMBUS 0x4385
#define PCI_DEVICE_ID_ATI_IXP600_IDE 0x438c
+#define PCI_DEVICE_ID_ATI_IXP700_SATA 0x4390
+#define PCI_DEVICE_ID_ATI_IXP700_SMBUS 0x4395
+#define PCI_DEVICE_ID_ATI_IXP700_IDE 0x439c
#define PCI_VENDOR_ID_VLSI 0x1004
#define PCI_DEVICE_ID_VLSI_82C592 0x0005
diff -Nur linux-2.6.21.1.orig/drivers/ide/pci/atiixp.c linux-2.6.21.1/drivers/ide/pci/atiixp.c
--- linux-2.6.21.1.orig/drivers/ide/pci/atiixp.c 2007-05-16 13:27:53.671011000 +0800
+++ linux-2.6.21.1/drivers/ide/pci/atiixp.c 2007-05-16 13:43:51.952261000 +0800
@@ -353,6 +353,7 @@
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
+ { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
{ 0, },
};
MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
[PATCH 4/4] Add the combined mode for ATI SB700
From: henry.su@amd.com
Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode.
The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver,
but now it is not necessary for Linux since the kernel has supported AHCI.
Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
-----------------------------------------------------
diff -Nur linux-2.6.21.1.orig/include/linux/pci_ids.h linux-2.6.21.1/include/linux/pci_ids.h
--- linux-2.6.21.1.orig/include/linux/pci_ids.h 2007-05-16 13:28:54.405386000 +0800
+++ linux-2.6.21.1/include/linux/pci_ids.h 2007-05-16 13:45:29.936636000 +0800
@@ -371,6 +371,9 @@
#define PCI_DEVICE_ID_ATI_IXP600_SRAID 0x4381
#define PCI_DEVICE_ID_ATI_IXP600_SMBUS 0x4385
#define PCI_DEVICE_ID_ATI_IXP600_IDE 0x438c
+#define PCI_DEVICE_ID_ATI_IXP700_SATA 0x4390
+#define PCI_DEVICE_ID_ATI_IXP700_SMBUS 0x4395
+#define PCI_DEVICE_ID_ATI_IXP700_IDE 0x439c
#define PCI_VENDOR_ID_VLSI 0x1004
#define PCI_DEVICE_ID_VLSI_82C592 0x0005
diff -Nur linux-2.6.21.1.orig/drivers/pci/quirks.c linux-2.6.21.1/drivers/pci/quirks.c
--- linux-2.6.21.1.orig/drivers/pci/quirks.c 2007-05-16 13:28:09.702261000 +0800
+++ linux-2.6.21.1/drivers/pci/quirks.c 2007-05-16 13:41:26.155386000 +0800
@@ -875,6 +875,7 @@
}
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_SATA, quirk_sb600_sata);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_sb600_sata);
/*
* Serverworks CSB5 IDE does not fully support native mode
-----Original Message-----
From: Bartlomiej Zolnierkiewicz [mailto:bzolnier@gmail.com]
Sent: Wednesday, May 16, 2007 6:37 AM
To: gmail_ati
Cc: Henry Su; linux-ide@vger.kernel.org
Subject: Re: [PATCH]add the IDE device ID for ATI SB700
Hi,
On Monday 14 May 2007, gmail_ati wrote:
> From: henry.su.ati@gmail.com
> add the IDE device ids to atiixp_pci_tbl struct in atiixp.c for ATI SB700.
> Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
This patch is somehow missing the chunk adding PCI_DEVICE_ID_ATI_IXP700_IDE
define to <linux/pci_ids.h> and thus makes atiixp.c fail to compile.
Please resend the complete patch.
PS your mailer seems to encode patches in some strange way (whitespaces are
mangled and saved email contained MIME encoded text instead of plain-text) so
I had to apply this change by hand. Not really a problem for this particular
patch ;) but definitively something needing fixing.
Thanks,
Bart
> -----------------------------------------------------
> diff -Nur linux-2.6.21.1.org/drivers/ide/pci/atiixp.c linux-2.6.21.1/drivers/ide/pci/atiixp.c
> --- linux-2.6.21.1.org/drivers/ide/pci/atiixp.c 2007-05-13 04:47:25.000000000 +0800
> +++ linux-2.6.21.1/drivers/ide/pci/atiixp.c 2007-05-13 05:14:08.000000000 +0800
> @@ -353,6 +353,7 @@
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
^ permalink raw reply [flat|nested] 4+ messages in thread