* [PATCH] Add two missing chipsets to drivers/ide/ide-proc.c
@ 2007-05-18 7:11 Mika Kukkonen
2007-05-23 23:50 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Mika Kukkonen @ 2007-05-18 7:11 UTC (permalink / raw)
To: bzolnier, alan; +Cc: mikukkon, linux-ide
Compiling with '-Wswitch-enum' I noticed following:
CC drivers/ide/ide-proc.o
drivers/ide/ide-proc.c: In function ‘proc_ide_read_imodel’:
drivers/ide/ide-proc.c:54: warning: enumeration value ‘ide_etrax100’ not handled in switch
drivers/ide/ide-proc.c:54: warning: enumeration value ‘ide_acorn’ not handled in switch
How about the following patch?
Signed-off-by: Mika Kukkonen <mikukkon@iki.fi>
diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c
index d50bd99..ea94c9a 100644
--- a/drivers/ide/ide-proc.c
+++ b/drivers/ide/ide-proc.c
@@ -67,6 +67,8 @@ static int proc_ide_read_imodel
case ide_4drives: name = "4drives"; break;
case ide_pmac: name = "mac-io"; break;
case ide_au1xxx: name = "au1xxx"; break;
+ case ide_etrax100: name = "etrax100"; break;
+ case ide_acorn: name = "acorn"; break;
default: name = "(unknown)"; break;
}
len = sprintf(page, "%s\n", name);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Add two missing chipsets to drivers/ide/ide-proc.c
2007-05-18 7:11 [PATCH] Add two missing chipsets to drivers/ide/ide-proc.c Mika Kukkonen
@ 2007-05-23 23:50 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-05-23 23:50 UTC (permalink / raw)
To: mikukkon; +Cc: alan, linux-ide
On Friday 18 May 2007, Mika Kukkonen wrote:
> Compiling with '-Wswitch-enum' I noticed following:
>
> CC drivers/ide/ide-proc.o
> drivers/ide/ide-proc.c: In function ‘proc_ide_read_imodel’:
> drivers/ide/ide-proc.c:54: warning: enumeration value ‘ide_etrax100’ not handled in switch
> drivers/ide/ide-proc.c:54: warning: enumeration value ‘ide_acorn’ not handled in switch
>
> How about the following patch?
>
> Signed-off-by: Mika Kukkonen <mikukkon@iki.fi>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-24 1:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-18 7:11 [PATCH] Add two missing chipsets to drivers/ide/ide-proc.c Mika Kukkonen
2007-05-23 23:50 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).