linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>, Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH] pata_it821x: (partially) fix DMA in RAID mode
Date: Mon, 11 Jun 2007 11:37:26 +0200	[thread overview]
Message-ID: <200706111137.26343.bzolnier@gmail.com> (raw)
In-Reply-To: <466CD502.6010201@garzik.org>

On Monday 11 June 2007, Jeff Garzik wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > Code intended to check DMA status was checking DMA command register.
> > 
> > Moreover firmware seems to "forget" to set DMA capable bit for the
> > slave device (at least in RAID mode but without ITE RAID volumes) so
> > check device ID for DMA capable bit when deciding whether to use DMA
> > and remove DMA status check completely.
> > 
> > Thanks to Pavol Šimo for the bugreport and testing the initial fix.
> > 
> > This change unfortunately still doesn't fix DMA in RAID mode (which
> > works fine with IDE it821x) but Alan is working on the missing pieces
> > (pata_it821x vs libata EH issues).
> > 
> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Cc: Tejun Heo <htejun@gmail.com>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > ---
> > 
> >  drivers/ata/pata_it821x.c |   11 +++--------
> >  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> Patch is OK but it's mangled by your mailer:
> 
> @@ -79,7 +80,7 @@
> =20
> =20
>   #define DRV_NAME "pata_it821x"
> =2D#define DRV_VERSION "0.3.6"
> +#define DRV_VERSION "0.3.7"
> =20
>   struct it821x_dev
>   {
> @@ -460,14 +461,8 @@ static unsigned int it821x_passthru_qc_i
> =20
> 
> =2D     int dma_enabled =3D 0;
>          int i;
> =20
> 
> etc.

Ah, non-ASCII char confused the mailer... resend.  Sorry for that.

  reply	other threads:[~2007-06-11  9:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-10 16:43 [PATCH] pata_it821x: (partially) fix DMA in RAID mode Bartlomiej Zolnierkiewicz
2007-06-10 17:42 ` Alan Cox
2007-06-11  4:52 ` Jeff Garzik
2007-06-11  9:37   ` Bartlomiej Zolnierkiewicz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-06-11  9:40 Bartlomiej Zolnierkiewicz
2007-06-20 23:56 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706111137.26343.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).