From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Cc: jeff@garzik.org, james.bottomley@steeleye.com,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, htejun@gmail.com,
arjan@linux.intel.com
Subject: Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.
Date: Mon, 11 Jun 2007 22:11:48 -0300 [thread overview]
Message-ID: <20070612011148.GA9808@khazad-dum.debian.net> (raw)
In-Reply-To: <20070611114839.907bcae2.kristen.c.accardi@intel.com>
On Mon, 11 Jun 2007, Kristen Carlson Accardi wrote:
> Setting Effect
> ----------------------------------------------------------
> min_power ALPM is enabled, and link set to enter
> lowest power state (SLUMBER) when idle
> Hot plug not allowed.
>
> max_performance ALPM is disabled, Hot Plug is allowed
>
> medium_power ALPM is enabled, and link set to enter
> second lowest power state (PARTIAL) when
> idle. Hot plug not allowed.
Just some food for thought:
If you split it into a enable/disable (0/1) attribute, and a level attribute
(some sort of integer scale, or "min", "medium", "max" if you must use
strings. You could use four levels to mimic the PCI device power state, for
example), it might make its usage more generic, and easier from userspace,
as it decouples the need to turn it on/off from the need to know which level
the user wants it set to when you turn it on.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2007-06-12 1:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070611184146.448266229@intel.com>
2007-06-11 18:48 ` [patch 1/3] Store interrupt value Kristen Carlson Accardi
2007-06-11 19:59 ` Jeff Garzik
2007-06-11 18:48 ` [patch 2/3] Expose Power Management Policy option to users Kristen Carlson Accardi
2007-06-11 20:00 ` Jeff Garzik
2007-06-12 17:46 ` [patch 2a/3] " Kristen Carlson Accardi
2007-06-13 15:26 ` James Bottomley
2007-06-13 20:48 ` Jeff Garzik
2007-06-14 16:39 ` Kristen Carlson Accardi
2007-06-14 17:44 ` Jeff Garzik
2007-06-12 17:47 ` [patch 2b/3] " Kristen Carlson Accardi
2007-06-20 21:22 ` Kristen Carlson Accardi
2007-06-11 18:48 ` [patch 3/3] Enable Aggressive Link Power management for AHCI controllers Kristen Carlson Accardi
2007-06-11 20:01 ` Jeff Garzik
2007-06-12 1:11 ` Henrique de Moraes Holschuh [this message]
2007-06-12 1:16 ` Arjan van de Ven
2007-06-12 1:54 ` Dagfinn Ilmari Mannsåker
2007-06-12 1:59 ` Jeff Garzik
2007-06-12 3:59 ` Henrique de Moraes Holschuh
2007-06-12 3:59 ` Arjan van de Ven
2007-06-12 9:09 ` Matthew Garrett
2007-06-12 12:18 ` Henrique de Moraes Holschuh
2007-06-12 13:50 ` Matthew Garrett
2007-06-12 14:17 ` Henrique de Moraes Holschuh
2007-06-12 15:38 ` Matthew Garrett
2007-06-12 15:45 ` Tejun Heo
2007-06-12 15:56 ` Matthew Garrett
2007-06-12 15:46 ` Jeff Garzik
2007-06-12 15:58 ` Matthew Garrett
2007-06-12 16:18 ` Jeff Garzik
2007-06-12 16:27 ` Kristen Carlson Accardi
2007-06-20 21:23 ` Kristen Carlson Accardi
2007-06-21 13:08 ` Jens Axboe
2007-06-22 17:15 ` Kristen Carlson Accardi
2007-06-22 19:00 ` Jens Axboe
2007-06-26 15:24 ` Kristen Carlson Accardi
[not found] <20070801210713.809095009@intel.com>
2007-08-01 21:29 ` Kristen Carlson Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612011148.GA9808@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=arjan@linux.intel.com \
--cc=htejun@gmail.com \
--cc=james.bottomley@steeleye.com \
--cc=jeff@garzik.org \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).