libata: ATA_PIIX missing ICH8M PCIIDs.

libata: ATA_PIIX missing ICH8M PCIIDs.

[Chr]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Hi,

I got a new laptop and I had a little problem that the DVD drive wasn't recognized by
libata's piix driver (but the old IDE Subsystem found it!).

So, after adding the new pciid 8086:2850 it works!
But, I don't know if it's ich_pata_100 or ich_pata_133 since the 
dvd/cd drives only goes up to udma2 speeds.

Thanks,
        Chr.

(I'm not on the list, please keep the cc!) 

-
this patch adds a necessary PCIID for santa rosa's PATA controller.

Signed-off-by: Christian Lamparter <chunkeey@web.de>

[-- Attachment #2: ich8m-add-pci-id.patch --]
[-- Type: text/x-diff, Size: 550 bytes --]

--- ata_piix.c.org	2007-06-17 12:58:17.000000000 +0200
+++ ata_piix.c	2007-06-17 13:00:24.000000000 +0200
@@ -201,6 +201,8 @@ static const struct pci_device_id piix_p
 	/* ICH7/7-R (i945, i975) UDMA 100*/
 	{ 0x8086, 0x27DF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },
 	{ 0x8086, 0x269E, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
+	/* ICH8 Mobile PATA Controller */
+	{ 0x8086, 0x2850, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
 
 	/* NOTE: The following PCI ids must be kept in sync with the
 	 * list in drivers/pci/quirks.c.

Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Alan Cox]

On Mon, 18 Jun 2007 15:20:06 +0200
Chr <chunkeey@web.de> wrote:

> Hi,
> 
> I got a new laptop and I had a little problem that the DVD drive wasn't recognized by
> libata's piix driver (but the old IDE Subsystem found it!).
> 
> So, after adding the new pciid 8086:2850 it works!
> But, I don't know if it's ich_pata_100 or ich_pata_133 since the 
> dvd/cd drives only goes up to udma2 speeds.

Its ich_pata_133 - all the newer chips are. They work even better if you
set them into AHCI mode in the BIOS and then they should "just work" with
recent kernels as the AHCI driver now matches by class.

Alan

Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Chr]

On Monday, 18. June 2007, Alan Cox wrote:
> On Mon, 18 Jun 2007 15:20:06 +0200
> Chr <chunkeey@web.de> wrote:
> 
> > Hi,
> > 
> > I got a new laptop and I had a little problem that the DVD drive wasn't recognized by
> > libata's piix driver (but the old IDE Subsystem found it!).
> > 
> > So, after adding the new pciid 8086:2850 it works!
> > But, I don't know if it's ich_pata_100 or ich_pata_133 since the 
> > dvd/cd drives only goes up to udma2 speeds.
> 
> Its ich_pata_133 - all the newer chips are. They work even better if you
> set them into AHCI mode in the BIOS and then they should "just work" with
> recent kernels as the AHCI driver now matches by class.
> 
> Alan
> 
> 

No go.. I've tried 2.6.20-1-amd64 (debian sid) and a vanilla 2.6.22-rc5.

(The "problem" is that there are no options for that in the BIOS. 
The BIOS itself is only useful on these laptops, if you want to set a BIOS
password, setting the system clock or change the boot order... and nothing else)

Thanks,
        Chr.

RE: libata: ATA_PIIX missing ICH8M PCIIDs.

[Gaston, Jason D]

FYI: DID 2850 is the PATA IDE controller.  Most likely, the laptop does not have SATA drives and is running off of PATA.  

The old IDE subsystem (piix.c) is where I added that PATA DID to.
#define PCI_DEVICE_ID_INTEL_ICH8_6	0x2850 in pci_ids.h

Jason



>-----Original Message-----
>From: linux-ide-owner@vger.kernel.org [mailto:linux-ide-
>owner@vger.kernel.org] On Behalf Of Chr
>Sent: Monday, June 18, 2007 6:53 AM
>To: linux-ide@vger.kernel.org
>Cc: chunkeey@web.de
>Subject: Re: libata: ATA_PIIX missing ICH8M PCIIDs.
>
>On Monday, 18. June 2007, Alan Cox wrote:
>> On Mon, 18 Jun 2007 15:20:06 +0200
>> Chr <chunkeey@web.de> wrote:
>>
>> > Hi,
>> >
>> > I got a new laptop and I had a little problem that the DVD drive wasn't
>recognized by
>> > libata's piix driver (but the old IDE Subsystem found it!).
>> >
>> > So, after adding the new pciid 8086:2850 it works!
>> > But, I don't know if it's ich_pata_100 or ich_pata_133 since the
>> > dvd/cd drives only goes up to udma2 speeds.
>>
>> Its ich_pata_133 - all the newer chips are. They work even better if you
>> set them into AHCI mode in the BIOS and then they should "just work" with
>> recent kernels as the AHCI driver now matches by class.
>>
>> Alan
>>
>>
>
>No go.. I've tried 2.6.20-1-amd64 (debian sid) and a vanilla 2.6.22-rc5.
>
>(The "problem" is that there are no options for that in the BIOS.
>The BIOS itself is only useful on these laptops, if you want to set a BIOS
>password, setting the system clock or change the boot order... and nothing
>else)
>
>Thanks,
>        Chr.
>-
>To unsubscribe from this list: send the line "unsubscribe linux-ide" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: libata: ATA_PIIX missing ICH8M PCIIDs.

[Gaston, Jason D]

I don't think we want to have a PATA controller DID added to the SATA IDE mode driver.  This DID is already in the PATA piix.c driver.

Jason



>-----Original Message-----
>From: linux-ide-owner@vger.kernel.org [mailto:linux-ide-
>owner@vger.kernel.org] On Behalf Of Chr
>Sent: Monday, June 18, 2007 6:20 AM
>To: linux-ide@vger.kernel.org
>Cc: chunkeey@web.de
>Subject: libata: ATA_PIIX missing ICH8M PCIIDs.
>
>Hi,
>
>I got a new laptop and I had a little problem that the DVD drive wasn't
>recognized by
>libata's piix driver (but the old IDE Subsystem found it!).
>
>So, after adding the new pciid 8086:2850 it works!
>But, I don't know if it's ich_pata_100 or ich_pata_133 since the
>dvd/cd drives only goes up to udma2 speeds.
>
>Thanks,
>        Chr.
>
>(I'm not on the list, please keep the cc!)
>
>-
>this patch adds a necessary PCIID for santa rosa's PATA controller.
>
>Signed-off-by: Christian Lamparter <chunkeey@web.de>

Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Chr]

On Monday, 18. June 2007, Gaston, Jason D wrote:
> FYI: DID 2850 is the PATA IDE controller.  Most likely, the laptop does not have SATA drives and is running off of PATA.  
> 
> The old IDE subsystem (piix.c) is where I added that PATA DID to.
> #define PCI_DEVICE_ID_INTEL_ICH8_6	0x2850 in pci_ids.h
> 
> Jason
> 

Yes, I've already said that the old IDE subsystem knows about ICH 8M 
(read the stuff in the brackets in the original post!).

But one day the old ide subsystem will be gone...
that's why I've added the PCIID to ata_piix.c "today", so I don't have to do it "tomorrow".

Another thing, Kconfig's description clearly states: "
config ATA_PIIX
	tristate "Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support"
...
	  This option enables support for ICH5/6/7/8 Serial ATA
	  and support for PATA on the Intel ESB/ICH/PIIX3/PIIX4 series
	  host controllers.
"

so, either change the description to:
"... support for PATA on the Intel ESB/ICH(all old chipsets 0,2,3M,3,4,5,6,7,7-R; but
not 8M, because you have use the old subsystem, for your "new" technology!)/PIIX3/PIIX4 series"

or accept the 1+1=2 logic and merge the patch into the git. 
(hint: but only after changing ich_pata_100 to ich_pata_133 of course!)

:D

Thanks, 
	Chr.
  
>
> >On Monday, 18. June 2007, Alan Cox wrote:
> >> On Mon, 18 Jun 2007 15:20:06 +0200
> >> Chr <chunkeey@web.de> wrote:
> >>
> >> > Hi,
> >> >
> >> > I got a new laptop and I had a little problem that the DVD drive wasn't
> >recognized by
> >> > libata's piix driver (but the old IDE Subsystem found it!).
> >> >
> >> > So, after adding the new pciid 8086:2850 it works!
> >> > But, I don't know if it's ich_pata_100 or ich_pata_133 since the
> >> > dvd/cd drives only goes up to udma2 speeds.
> >>
> >> Its ich_pata_133 - all the newer chips are. They work even better if you
> >> set them into AHCI mode in the BIOS and then they should "just work" with
> >> recent kernels as the AHCI driver now matches by class.
> >>
> >> Alan
> >>
> >>
> >
> >No go.. I've tried 2.6.20-1-amd64 (debian sid) and a vanilla 2.6.22-rc5.
> >
> >(The "problem" is that there are no options for that in the BIOS.
> >The BIOS itself is only useful on these laptops, if you want to set a BIOS
> >password, setting the system clock or change the boot order... and nothing
> >else)
> >
> >Thanks,
> >        Chr.
> >-

RE: libata: ATA_PIIX missing ICH8M PCIIDs.

[Gaston, Jason D]

I don't think we want to have the same DeviceID supported in more then one driver.  Would they not conflict with each other?

Jason



>-----Original Message-----
>From: chunkeey@web.de [mailto:chunkeey@web.de]
>Sent: Monday, June 18, 2007 11:50 AM
>To: Gaston, Jason D
>Cc: linux-ide@vger.kernel.org
>Subject: Re: libata: ATA_PIIX missing ICH8M PCIIDs.
>
>On Monday, 18. June 2007, Gaston, Jason D wrote:
>> FYI: DID 2850 is the PATA IDE controller.  Most likely, the laptop does
>not have SATA drives and is running off of PATA.
>>
>> The old IDE subsystem (piix.c) is where I added that PATA DID to.
>> #define PCI_DEVICE_ID_INTEL_ICH8_6	0x2850 in pci_ids.h
>>
>> Jason
>>
>
>Yes, I've already said that the old IDE subsystem knows about ICH 8M
>(read the stuff in the brackets in the original post!).
>
>But one day the old ide subsystem will be gone...
>that's why I've added the PCIID to ata_piix.c "today", so I don't have to
>do it "tomorrow".
>
>Another thing, Kconfig's description clearly states: "
>config ATA_PIIX
>	tristate "Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support"
>...
>	  This option enables support for ICH5/6/7/8 Serial ATA
>	  and support for PATA on the Intel ESB/ICH/PIIX3/PIIX4 series
>	  host controllers.
>"
>
>so, either change the description to:
>"... support for PATA on the Intel ESB/ICH(all old chipsets
>0,2,3M,3,4,5,6,7,7-R; but
>not 8M, because you have use the old subsystem, for your "new"
>technology!)/PIIX3/PIIX4 series"
>
>or accept the 1+1=2 logic and merge the patch into the git.
>(hint: but only after changing ich_pata_100 to ich_pata_133 of course!)
>
>:D
>
>Thanks,
>	Chr.
>
>>
>> >On Monday, 18. June 2007, Alan Cox wrote:
>> >> On Mon, 18 Jun 2007 15:20:06 +0200
>> >> Chr <chunkeey@web.de> wrote:
>> >>
>> >> > Hi,
>> >> >
>> >> > I got a new laptop and I had a little problem that the DVD drive
>wasn't
>> >recognized by
>> >> > libata's piix driver (but the old IDE Subsystem found it!).
>> >> >
>> >> > So, after adding the new pciid 8086:2850 it works!
>> >> > But, I don't know if it's ich_pata_100 or ich_pata_133 since the
>> >> > dvd/cd drives only goes up to udma2 speeds.
>> >>
>> >> Its ich_pata_133 - all the newer chips are. They work even better if
>you
>> >> set them into AHCI mode in the BIOS and then they should "just work"
>with
>> >> recent kernels as the AHCI driver now matches by class.
>> >>
>> >> Alan
>> >>
>> >>
>> >
>> >No go.. I've tried 2.6.20-1-amd64 (debian sid) and a vanilla 2.6.22-rc5.
>> >
>> >(The "problem" is that there are no options for that in the BIOS.
>> >The BIOS itself is only useful on these laptops, if you want to set a
>BIOS
>> >password, setting the system clock or change the boot order... and
>nothing
>> >else)
>> >
>> >Thanks,
>> >        Chr.
>> >-

Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Chr]

On Monday, 18. June 2007, you wrote:
> I don't think we want to have the same DeviceID supported in more then one driver.  Would they not conflict with each other?
> 
> Jason
> 
please bottom post!

about your concerns:

see: pci_id.h
#define PCI_DEVICE_ID_INTEL_ICH6_19     0x266f
#define PCI_DEVICE_ID_INTEL_ICH7_21     0x27df

then look in piix.c:
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH6_19, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 20},
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_21, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 21},

and check ata_piix.c:
        /* ICH6 (and 6) (i915) UDMA 100 */
        { 0x8086, 0x266F, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
        /* ICH7/7-R (i945, i975) UDMA 100*/
        { 0x8086, 0x27DF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },

unfortunatly, it already happend... worse: it's already in vanilla! any complains? no??????

Thanks,
	Chr.

> 
> 
> >-----Original Message-----
> >From: chunkeey@web.de [mailto:chunkeey@web.de]
> >Sent: Monday, June 18, 2007 11:50 AM
> >To: Gaston, Jason D
> >Cc: linux-ide@vger.kernel.org
> >Subject: Re: libata: ATA_PIIX missing ICH8M PCIIDs.
> >
> >On Monday, 18. June 2007, Gaston, Jason D wrote:
> >> FYI: DID 2850 is the PATA IDE controller.  Most likely, the laptop does
> >not have SATA drives and is running off of PATA.
> >>
> >> The old IDE subsystem (piix.c) is where I added that PATA DID to.
> >> #define PCI_DEVICE_ID_INTEL_ICH8_6 0x2850 in pci_ids.h
> >>
> >> Jason
> >>
> >
> >Yes, I've already said that the old IDE subsystem knows about ICH 8M
> >(read the stuff in the brackets in the original post!).
> >
> >But one day the old ide subsystem will be gone...
> >that's why I've added the PCIID to ata_piix.c "today", so I don't have to
> >do it "tomorrow".
> >
> >Another thing, Kconfig's description clearly states: "
> >config ATA_PIIX
> >     tristate "Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support"
> >...
> >       This option enables support for ICH5/6/7/8 Serial ATA
> >       and support for PATA on the Intel ESB/ICH/PIIX3/PIIX4 series
> >       host controllers.
> >"
> >
> >so, either change the description to:
> >"... support for PATA on the Intel ESB/ICH(all old chipsets
> >0,2,3M,3,4,5,6,7,7-R; but
> >not 8M, because you have use the old subsystem, for your "new"
> >technology!)/PIIX3/PIIX4 series"
> >
> >or accept the 1+1=2 logic and merge the patch into the git.
> >(hint: but only after changing ich_pata_100 to ich_pata_133 of course!)
> >
> >:D
> >
> >Thanks,
> >     Chr.
> >
> >>

Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Jeff Garzik]

Gaston, Jason D wrote:
> I don't think we want to have the same DeviceID supported in more then one driver.  Would they not conflict with each other?

In Fedora 7, CONFIG_IDE is disabled.  ata_piix drives all hardware at 
that point.

	Jeff

Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Chr]

On Monday, 18. June 2007, Gaston, Jason D wrote:
> 
> I hate outlook...
>
> 
> As PATA is going away, hopefully this will be a moot point.
> 
yes, PATA served well, but Intel has already done the necessary
ceremony for PATA's funreal. ICH8M is maybe really the last
chipset with a "native" IDE interface.

But, "There's life in the old dog yet." and AGP is not dead yet too! 

uahauh, it's a kind of spooky, with
all of these zombies and braindead monsters like outlook. ;)

Thanks,
	Chr.
> 
> 

Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Chr]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

On Monday, 18. June 2007, Jeff Garzik wrote:
> Gaston, Jason D wrote:
> > I don't think we want to have the same DeviceID supported in more then one driver.  Would they not conflict with each other?
> 
> In Fedora 7, CONFIG_IDE is disabled.  ata_piix drives all hardware at 
> that point.
> 
> 	Jeff

here's a updated version. (thanks alan for pointing out that it's a ich_pata_133..) 
OK/(N)ACK/...? 

-
this patch adds a necessary PCIID for Santa Rosa's PATA controller.

Signed-off-by: Christian Lamparter <chunkeey@web.de>
-


[-- Attachment #2: ich8m-add-pci-id.patch --]
[-- Type: text/x-diff, Size: 550 bytes --]

--- ata_piix.c.org	2007-06-17 12:58:17.000000000 +0200
+++ ata_piix.c	2007-06-17 13:00:24.000000000 +0200
@@ -201,6 +201,8 @@ static const struct pci_device_id piix_p
 	/* ICH7/7-R (i945, i975) UDMA 100*/
 	{ 0x8086, 0x27DF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },
 	{ 0x8086, 0x269E, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
+	/* ICH8 Mobile PATA Controller */
+	{ 0x8086, 0x2850, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },
 
 	/* NOTE: The following PCI ids must be kept in sync with the
 	 * list in drivers/pci/quirks.c.

Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Alan Cox]

On Mon, 18 Jun 2007 11:00:33 -0700
"Gaston, Jason D" <jason.d.gaston@intel.com> wrote:

> I don't think we want to have a PATA controller DID added to the SATA IDE mode driver.  

ata_piix drives both

Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Alan Cox]

On Mon, 18 Jun 2007 11:57:16 -0700
"Gaston, Jason D" <jason.d.gaston@intel.com> wrote:

> I don't think we want to have the same DeviceID supported in more then one driver.  Would they not conflict with each other?

Nope  and drivers/ide is going away (eventually)

Alan

[PATCH] libata: adding ICH8M PCIIDs to ATA_PIIX.

[Chr]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

On Monday, 18. June 2007, Jeff Garzik wrote:
> Gaston, Jason D wrote:
> > I don't think we want to have the same DeviceID supported in more then one driver.  Would they not conflict with each other?
> 
> In Fedora 7, CONFIG_IDE is disabled.  ata_piix drives all hardware at 
> that point.
> 
> 	Jeff


Hmm, did I forgot anything important in the last mail, or is everyone just busy?
(please keep CC!)

---
This patch adds a necessary PCIID for Santa Rosa's PATA controller.

Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
 drivers/ata/ata_piix.c |    2 ++
 1 file changed, 2 insertions(+)



[-- Attachment #2: ich8m-add-pciid.patch --]
[-- Type: text/x-diff, Size: 594 bytes --]

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 9c07b88..b210726 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -200,6 +200,8 @@ static const struct pci_device_id piix_pci_tbl[] = {
 	/* ICH7/7-R (i945, i975) UDMA 100*/
 	{ 0x8086, 0x27DF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },
 	{ 0x8086, 0x269E, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
+	/* ICH8 Mobile PATA Controller */
+	{ 0x8086, 0x2850, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },
 
 	/* NOTE: The following PCI ids must be kept in sync with the
 	 * list in drivers/pci/quirks.c.