Re: libata: ATA_PIIX missing ICH8M PCIIDs.

[Chr <chunkeey@web.de>]

On Monday, 18. June 2007, you wrote:
> I don't think we want to have the same DeviceID supported in more then one driver.  Would they not conflict with each other?
> 
> Jason
> 
please bottom post!

about your concerns:

see: pci_id.h
#define PCI_DEVICE_ID_INTEL_ICH6_19     0x266f
#define PCI_DEVICE_ID_INTEL_ICH7_21     0x27df

then look in piix.c:
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH6_19, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 20},
        { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_21, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 21},

and check ata_piix.c:
        /* ICH6 (and 6) (i915) UDMA 100 */
        { 0x8086, 0x266F, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
        /* ICH7/7-R (i945, i975) UDMA 100*/
        { 0x8086, 0x27DF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_133 },

unfortunatly, it already happend... worse: it's already in vanilla! any complains? no??????

Thanks,
	Chr.

> 
> 
> >-----Original Message-----
> >From: chunkeey@web.de [mailto:chunkeey@web.de]
> >Sent: Monday, June 18, 2007 11:50 AM
> >To: Gaston, Jason D
> >Cc: linux-ide@vger.kernel.org
> >Subject: Re: libata: ATA_PIIX missing ICH8M PCIIDs.
> >
> >On Monday, 18. June 2007, Gaston, Jason D wrote:
> >> FYI: DID 2850 is the PATA IDE controller.  Most likely, the laptop does
> >not have SATA drives and is running off of PATA.
> >>
> >> The old IDE subsystem (piix.c) is where I added that PATA DID to.
> >> #define PCI_DEVICE_ID_INTEL_ICH8_6 0x2850 in pci_ids.h
> >>
> >> Jason
> >>
> >
> >Yes, I've already said that the old IDE subsystem knows about ICH 8M
> >(read the stuff in the brackets in the original post!).
> >
> >But one day the old ide subsystem will be gone...
> >that's why I've added the PCIID to ata_piix.c "today", so I don't have to
> >do it "tomorrow".
> >
> >Another thing, Kconfig's description clearly states: "
> >config ATA_PIIX
> >     tristate "Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support"
> >...
> >       This option enables support for ICH5/6/7/8 Serial ATA
> >       and support for PATA on the Intel ESB/ICH/PIIX3/PIIX4 series
> >       host controllers.
> >"
> >
> >so, either change the description to:
> >"... support for PATA on the Intel ESB/ICH(all old chipsets
> >0,2,3M,3,4,5,6,7,7-R; but
> >not 8M, because you have use the old subsystem, for your "new"
> >technology!)/PIIX3/PIIX4 series"
> >
> >or accept the 1+1=2 logic and merge the patch into the git.
> >(hint: but only after changing ich_pata_100 to ich_pata_133 of course!)
> >
> >:D
> >
> >Thanks,
> >     Chr.
> >
> >>