From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Mark Lord <liml@rtr.ca>,
jeff@garzik.org, davej@redhat.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide
Date: Sat, 23 Jun 2007 19:41:34 +0200 [thread overview]
Message-ID: <200706231941.34557.bzolnier@gmail.com> (raw)
In-Reply-To: <20070622202610.3b805cfe@the-village.bc.nu>
Hi,
On Friday 22 June 2007, Alan Cox wrote:
> > > I think a /sys/ "dma" attribute (pick a name) might be most appropriate,
> > > or we just just implement HDIO_[GS]ET_DMA as a simpler/lazier mechanism.
> >
> > The problem is that libata lacks any locking needed for having this
> > (and other useful) settings tunable on per device basis.
>
> Actually libata does have the paths for it and uses them when drives are
> hotplugged. Tejun posted an explanation of how to implement it a while
> ago when I proposed a totally bogus implementation - it has to be done
> via the EH code.
I must have missed the original discussion.
> So we'd add user mode masks to each device and the sysfs nodes would
> update that mask and trigger the EH processing to halt activity, retune
> the disks and continue
Sounds good.
Thanks,
Bart
prev parent reply other threads:[~2007-06-23 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 13:49 [PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide Alan Cox
2007-06-22 15:01 ` Mark Lord
2007-06-22 15:52 ` Alan Cox
2007-06-22 16:53 ` Mark Lord
2007-06-22 19:04 ` Bartlomiej Zolnierkiewicz
2007-06-22 19:26 ` Alan Cox
2007-06-23 17:41 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706231941.34557.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).