Re: [PATCH] ide: Stop mapping ROMs

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

Hi,

On Friday 22 June 2007, Sergei Shtylyov wrote:
> Hello.
> 
> Alan Cox wrote:
> 
> > Various old IDE drivers go mapping ROM devices for no apparent reason and
> > without using the ROM mapping API we now have. They don't actually use
> 
>     Hm, do you mean the sysfs based aproach? I've tried that and somehow it 
> failed to work for me -- that's because I deferred removing this stuff from 
> the drivers.

Could you elaborate a bit about sysfs based approach?

If it indeed doesn't work we should ping PCI people about it.

> > the ROM they map and the new libata drivers are happy without it being
> 
>     I guess ROMs used to be mappen just for dumping BIOSes...
> 
> > mapped so rather than port them lets just junk it for the next -rc1.
> 
>     I'd agree to the patch -- the drivers were mapping ROMs in a bad way, 
> often using the default addresses.

I added your ACK to the patch.

Thanks,
Bart