Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Sunday 01 July 2007, Jeff Garzik wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > * Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags
> >   and set them in ht6560, cmd640, cmd64x and sc1200 host drivers.
> > 
> > * Add set_pio_mode_abuse() for checking if host driver has a non-standard
> >   ->tuneproc() implementation and use it in do_special().
> > 
> > * Add ide_set_pio() for setting PIO mode (it uses hwif->pio_mask to find
> >   the maximum PIO mode supported by the host), also add ide_set_max_pio()
> >   wrapper for ide_set_pio() to use for auto-tuning.  Convert users of
> >   ->tuneproc to use ide_set{_max}_pio() where possible.  This leaves only
> >   do_special(), set_using_pio(), ide_hwif_restore() and ide_set_pio() as
> >   a direct users of ->tuneproc.
> > 
> > * Remove no longer needed ide_get_best_pio_mode() calls and printk-s
> >   reporting PIO mode selected from ->tuneproc implementations.
> > 
> > * Rename ->tuneproc hook to ->set_pio_mode and make 'pio' argument const.
> > 
> > * Remove stale comment from ide_config_drive_speed().
> > 
> > v2:
> > * Fix "ata_" prefix (Noticed by Jeff).
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Cc: Jeff Garzik <jeff@garzik.org>
> 
> Thanks Bart!

np, thanks for bringing my attention to the issue

I just completely forgot about shared namespace / backtraces
and was happily intending to add more "ata_" prefixes to tag
code areas dealt with... :)

I will just blame too much IDE hacking to have caused some
kind of tunnel vision.

Bart