From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space Date: Mon, 2 Jul 2007 20:41:08 +0200 Message-ID: <200707022041.08350.bzolnier@gmail.com> References: <200706302110.20766.bzolnier@gmail.com> <200707021956.32844.bzolnier@gmail.com> <46893D42.9070603@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ug-out-1314.google.com ([66.249.92.172]:60648 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736AbXGBSYS (ORCPT ); Mon, 2 Jul 2007 14:24:18 -0400 Received: by ug-out-1314.google.com with SMTP id j3so1312740ugf for ; Mon, 02 Jul 2007 11:24:17 -0700 (PDT) In-Reply-To: <46893D42.9070603@garzik.org> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Sergei Shtylyov , linux-ide@vger.kernel.org On Monday 02 July 2007, Jeff Garzik wrote: > Bartlomiej Zolnierkiewicz wrote: > > This would brake setups which currently work OK, i.e. BIOS set things up > > (reminds me about cmd64x vs broken MWDMA)... > > > > The RightThing(tm) to do is to fix alim15x3 driver to program DMA timings > > (especially given that pata_ali seems to already contain the needed code). > > I am not ready to trust that pata_ali works as well as alim15x3 in all > cases. Someone should test e.g. Alpha AXP systems with IDE (use > alim15x3) to make sure all is well. Sure but there is no problem with the new code in alim15x3 being X86 until it is verified to work with Alpha AXP machines etc... > alim15x3 covers buggy, ugly, quirky chipsets. I consider that coverage > in general highly fragile. and in case of MWDMA modes also highly dependent on BIOS settings which very likely results in broken suspend/resume... Thanks, Bart