From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space
Date: Mon, 2 Jul 2007 21:53:16 +0200 [thread overview]
Message-ID: <200707022153.16964.bzolnier@gmail.com> (raw)
In-Reply-To: <46894F3B.7050600@garzik.org>
On Monday 02 July 2007, Jeff Garzik wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > Add the new code inside #ifdef X86, marking alim15x3 X86-only would be
> > on over-kill...
My reply is taken out of context.
> Ugh. That's not how we do Linux development. It is better to convert
> the new code and wait for alpha/sparc users to scream, than add platform
> ifdefs. To do so creates divergent code paths, that runs counter to
> Linux's goal of a portable driver.
I insisted on changes being done in "Linux style" since the begging but you've
complained about it and requested prior testing of the changes on alpha/sparc.
Maybe I misunderstood your first mail, if this is the case then we are fully
agreed and there are no discrepancies in our views on development style.
Thanks,
Bart
next prev parent reply other threads:[~2007-07-02 19:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 19:10 [PATCH 12/15] alim15x3: ->speedproc, filter out invalid modes passed from user-space Bartlomiej Zolnierkiewicz
2007-07-02 15:42 ` Sergei Shtylyov
2007-07-02 17:56 ` Bartlomiej Zolnierkiewicz
2007-07-02 18:00 ` Jeff Garzik
2007-07-02 18:41 ` Bartlomiej Zolnierkiewicz
2007-07-02 18:31 ` Jeff Garzik
2007-07-02 18:55 ` Bartlomiej Zolnierkiewicz
2007-07-02 19:13 ` Bartlomiej Zolnierkiewicz
2007-07-02 19:17 ` Jeff Garzik
2007-07-02 19:53 ` Bartlomiej Zolnierkiewicz [this message]
2007-07-02 19:22 ` Alan Cox
2007-07-02 19:20 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707022153.16964.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).