* [PATCH 6/12] jmicron: PIO fixes
@ 2007-07-08 13:36 Bartlomiej Zolnierkiewicz
2007-07-09 14:09 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-08 13:36 UTC (permalink / raw)
To: linux-ide
* Set transfer mode on the device in jmicron_tuneproc(),
also add pio == 255 == "auto-tune" handling.
* Use jmicron_tuneproc() in jmicron_config_drive_for_dma().
* Remove no longer needed config_jmicron_chipset_for_pio().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/pci/jmicron.c | 21 ++++-----------------
1 file changed, 4 insertions(+), 17 deletions(-)
Index: b/drivers/ide/pci/jmicron.c
===================================================================
--- a/drivers/ide/pci/jmicron.c
+++ b/drivers/ide/pci/jmicron.c
@@ -83,23 +83,10 @@ static u8 __devinit ata66_jmicron(ide_hw
return ATA_CBL_PATA80;
}
-static void jmicron_tuneproc (ide_drive_t *drive, byte mode_wanted)
+static void jmicron_tuneproc(ide_drive_t *drive, u8 pio)
{
- return;
-}
-
-/**
- * config_jmicron_chipset_for_pio - set drive timings
- * @drive: drive to tune
- * @speed we want
- *
- */
-
-static void config_jmicron_chipset_for_pio (ide_drive_t *drive, byte set_speed)
-{
- u8 speed = XFER_PIO_0 + ide_get_best_pio_mode(drive, 255, 5);
- if (set_speed)
- (void) ide_config_drive_speed(drive, speed);
+ pio = ide_get_best_pio_mode(drive, pio, 5);
+ ide_config_drive_speed(drive, XFER_PIO_0 + pio);
}
/**
@@ -132,7 +119,7 @@ static int jmicron_config_drive_for_dma
if (ide_tune_dma(drive))
return 0;
- config_jmicron_chipset_for_pio(drive, 1);
+ jmicron_tuneproc(drive, 255);
return -1;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 6/12] jmicron: PIO fixes
2007-07-08 13:36 [PATCH 6/12] jmicron: PIO fixes Bartlomiej Zolnierkiewicz
@ 2007-07-09 14:09 ` Sergei Shtylyov
2007-07-10 20:26 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2007-07-09 14:09 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> * Set transfer mode on the device in jmicron_tuneproc(),
> also add pio == 255 == "auto-tune" handling.
> * Use jmicron_tuneproc() in jmicron_config_drive_for_dma().
> * Remove no longer needed config_jmicron_chipset_for_pio().
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 6/12] jmicron: PIO fixes
2007-07-09 14:09 ` Sergei Shtylyov
@ 2007-07-10 20:26 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-10 20:26 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide
On Monday 09 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Set transfer mode on the device in jmicron_tuneproc(),
> > also add pio == 255 == "auto-tune" handling.
>
> > * Use jmicron_tuneproc() in jmicron_config_drive_for_dma().
>
> > * Remove no longer needed config_jmicron_chipset_for_pio().
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
added
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-10 22:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-08 13:36 [PATCH 6/12] jmicron: PIO fixes Bartlomiej Zolnierkiewicz
2007-07-09 14:09 ` Sergei Shtylyov
2007-07-10 20:26 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).