Re: Question about PATA Sil680 Bus Reset Code

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Tuesday 10 July 2007, Sergei Shtylyov wrote:
> Alan Cox wrote:
> 
> >>    I guess it's been blindly copied over form drivers/ide/pci/siimage.c...
> 
>     Yet the order of events between IDE and libata drivers is different:
> the old driver's resetproc() method is called just after the twiddling the bit 
> on/off,  the new driver calls ata_std_softreset() after the PCI config. 
> register manipulation.  However, since all it does is set 2 read-only bits, it 
> should make no difference...
> 
> >>The code indeed does seem meaningless. For the libata it could make sense to 
> >>set bit 2 for the hardreset -- but then sil680_error_handler() needs to be 
> >>turn into ata_bmdma_drive_eh(ap, ata_std_prereset, ata_std_softreset, 
> >>sil680_bus_reset, ata_std_postreset)...
> >>    For the legacy driver, this function needs to be converted to something 
> >>sane too...
> 
> > I think the evidence based upon years of highly reliable siimage usage is
> > that its simply not needed 8)
> 
>     I would think so as well but was not sure about the SStatus reg. read at 
> the end of it...

Could you send a patch removing a said code?

Thanks,
Bart