From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 4/12] cs5535: PIO fixes
Date: Fri, 13 Jul 2007 21:49:47 +0200 [thread overview]
Message-ID: <200707132149.47631.bzolnier@gmail.com> (raw)
In-Reply-To: <46979A07.2030100@ru.mvista.com>
On Friday 13 July 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Fix cs5535_tuneproc() to pass PIO transfer mode value instead of PIO mode
> > number to cs5535_set_speed() (fixes random PIO timings being programmed
> > and a possible OOPS). Do a little cleanup while at it.
>
> > * Fix cs5535_set_speed() to check if the mate device is present (fixes PIO0
> > taskfile timings being used if there is no other device on the cable).
>
> > * Use cs5535_tuneproc() in cs5535_dma_check(). The old code had the same
> > issue as cs5535_tuneproc() and add additionally caused 0x00-0x04 transfer
> > mode values (== default PIO, default PIO w/ IORDY + two invalid values)
> > being set on the device instead of values 0x08-0x0c (XFER_PIO_[0,4]).
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
added
prev parent reply other threads:[~2007-07-13 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 13:34 [PATCH 4/12] cs5535: PIO fixes Bartlomiej Zolnierkiewicz
2007-07-13 15:28 ` Sergei Shtylyov
2007-07-13 19:49 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707132149.47631.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).