linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
	linux-ide@vger.kernel.org,
	owner-linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 1/2] PCI: rename and export __pci_reenable_device()
Date: Tue, 17 Jul 2007 10:05:38 -0700	[thread overview]
Message-ID: <20070717170538.GA2281@kroah.com> (raw)
In-Reply-To: <20070711103204.GE23568@htj.dyndns.org>

On Wed, Jul 11, 2007 at 07:32:04PM +0900, Tejun Heo wrote:
> Some odd ACPI implementations choke if certain controller is disabled
> when ACPI suspend is invoked but we still need to make sure the PCI
> device is enabled during resume.  Simply using pci_enable_device()
> unbalances device enable count.
> 
> Drop leading underscores from __pci_reenable_device() and export it.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

Jeff, I'm guessing this will go through your tree as the ata patch after
this needs this change.

If so, feel free to add my:

	Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

to the patch, I have no objection to it.

thanks,

greg k-h

      parent reply	other threads:[~2007-07-17 17:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-10  6:36 [PATCH 1/2] PCI: export __pci_reenable_device() Tejun Heo
2007-07-10  6:55 ` [PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops Tejun Heo
2007-07-24 20:59   ` Jeff Garzik
2007-07-24 21:57     ` Alan Cox
2007-07-24 22:05       ` Jeff Garzik
2007-07-27  5:43         ` [PATCH] pci: rename __pci_reenable_device() to pci_reenable_device() Tejun Heo
2007-07-27  5:53           ` [PATCH] ata_piix: implement piix_borken_suspend() Tejun Heo
2007-07-27  5:55             ` [PATCH] ata_piix: add Tecra M3 to broken suspend blacklist Tejun Heo
2007-07-27  6:22           ` [PATCH] pci: rename __pci_reenable_device() to pci_reenable_device() Greg KH
2007-08-01 14:02           ` Jeff Garzik
2007-07-10 16:17 ` [PATCH 1/2] PCI: export __pci_reenable_device() Greg KH
2007-07-11 10:32   ` [PATCH 1/2] PCI: rename and " Tejun Heo
2007-07-11 10:32     ` [PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops Tejun Heo
2007-07-17 17:05     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070717170538.GA2281@kroah.com \
    --to=greg@kroah.com \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=owner-linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).