From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/4] alim15x3: PIO mode setup fixes
Date: Sun, 22 Jul 2007 20:47:52 +0200 [thread overview]
Message-ID: <200707222047.52273.bzolnier@gmail.com> (raw)
In-Reply-To: <46A0AF9A.3060401@ru.mvista.com>
On Friday 20 July 2007, Sergei Shtylyov wrote:
> Hi.
>
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Return failure in ->speedproc method for unsupported/invalid transfer
> > modes passed from user-space (fixes theoretical OOPS in ali_tune_pio()
> > and/or setting random PIO timings on host controller + disabling UDMA
> > bit + setting unsupported/invalid transfer mode on the device).
>
> > * Don't disable UDMA bit when programming PIO modes.
>
> Not an issue per se sice ide_config_drive_speed() will turn DMA off anyway
> (unless a drive denies to set a given xfer mode).
Yep but it is needed for patch #4/4.
> > * Add FIXME about DMA timings never being set.
>
> > * Bump driver version.
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
added
prev parent reply other threads:[~2007-07-22 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 10:24 [PATCH 1/4] alim15x3: PIO mode setup fixes Bartlomiej Zolnierkiewicz
2007-07-20 12:50 ` Sergei Shtylyov
2007-07-22 18:47 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707222047.52273.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).