From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 11/11] ide-pmac: remove pmac_ide_do_setfeature() (take 2)
Date: Thu, 26 Jul 2007 20:04:15 +0200 [thread overview]
Message-ID: <200707262004.15566.bzolnier@gmail.com> (raw)
In-Reply-To: <1185230714.5439.150.camel@localhost.localdomain>
On Tuesday 24 July 2007, Benjamin Herrenschmidt wrote:
> On Tue, 2007-07-24 at 00:29 +0200, Bartlomiej Zolnierkiewicz wrote:
> > Use ide_config_drive_speed() instead of pmac_ide_do_setfeature() and remove
> > the latter, also ide-iops.c::__ide_wait_stat() could be static again.
> >
> > Since for IDE PMAC host driver IDE_CONTROL_REG is always true, device's
> > ->quirk_list is always zero and ->ide_dma_host_{on,off} are nops than
> > the only changes in behavior are:
> >
> > * if PIO mode is set then ->dma_off_queitly is called to disable DMA
> >
> > * if setting transfer mode fails ide_dump_status() is called to dump status
>
> I'll test that today.
ping?
next prev parent reply other threads:[~2007-07-26 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 22:29 [PATCH 11/11] ide-pmac: remove pmac_ide_do_setfeature() (take 2) Bartlomiej Zolnierkiewicz
2007-07-23 22:45 ` Benjamin Herrenschmidt
2007-07-26 18:04 ` Bartlomiej Zolnierkiewicz [this message]
2007-07-26 21:33 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707262004.15566.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).