From: Eric Sesterhenn / Snakebyte <snakebyte@gmx.de>
To: Venki Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Eric Sesterhenn / Snakebyte <snakebyte@gmx.de>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-acpi@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Time Problems with 2.6.23-rc1-gf695baf2
Date: Tue, 31 Jul 2007 22:08:25 +0200 [thread overview]
Message-ID: <20070731200825.GB28917@alice> (raw)
In-Reply-To: <20070731190431.GA24577@linux-os.sc.intel.com>
* Venki Pallipadi (venkatesh.pallipadi@intel.com) wrote:
> Can you check the test patch below (over latest git) and let me know whether it
> resolves the issue.
>
the patch fixes the issue for me,
thanks a lot.
Eric
> Enable C3 without bm control only for CST based C3.
>
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>
> Index: linux-2.6/drivers/acpi/processor_idle.c
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/processor_idle.c 2007-07-31 04:29:26.000000000 -0700
> +++ linux-2.6/drivers/acpi/processor_idle.c 2007-07-31 04:52:50.000000000 -0700
> @@ -969,11 +969,17 @@
> }
>
> if (pr->flags.bm_check) {
> - /* bus mastering control is necessary */
> if (!pr->flags.bm_control) {
> - /* In this case we enter C3 without bus mastering */
> - ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> - "C3 support without bus mastering control\n"));
> + if (pr->flags.has_cst != 1) {
> + /* bus mastering control is necessary */
> + ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> + "C3 support requires BM control\n"));
> + return;
> + } else {
> + /* Here we enter C3 without bus mastering */
> + ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> + "C3 support without BM control\n"));
> + }
> }
> } else {
> /*
prev parent reply other threads:[~2007-07-31 20:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070723221630.GA28951@alice>
2007-07-24 23:14 ` Time Problems with 2.6.23-rc1-gf695baf2 Michal Piotrowski
2007-07-25 0:40 ` Bartlomiej Zolnierkiewicz
2007-07-25 1:14 ` Bartlomiej Zolnierkiewicz
2007-07-25 11:33 ` Eric Sesterhenn / Snakebyte
2007-07-25 16:50 ` Len Brown
2007-07-25 23:17 ` Eric Sesterhenn / Snakebyte
2007-07-30 14:32 ` Michal Piotrowski
2007-07-31 14:54 ` Eric Sesterhenn / Snakebyte
2007-07-31 15:15 ` Pallipadi, Venkatesh
2007-07-31 15:38 ` Eric Sesterhenn / Snakebyte
2007-07-31 19:04 ` Venki Pallipadi
2007-07-31 20:08 ` Eric Sesterhenn / Snakebyte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070731200825.GB28917@alice \
--to=snakebyte@gmx.de \
--cc=bzolnier@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).