* [PATCH 10/11] ide-pmac: add PIO autotune fallback to ->ide_dma_check
@ 2007-08-04 20:12 Bartlomiej Zolnierkiewicz
2007-08-06 16:43 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-08-04 20:12 UTC (permalink / raw)
To: linux-ide; +Cc: Benjamin Herrenschmidt
Since ide-pmac allows separate PIO and DMA timings, and ide-pmac always sets
->autotune this change shouldn't have any other effect than bringing ide-pmac
driver in-line with other host drivers wrt ->ide_dma_check implementation.
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ppc/pmac.c | 2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/ide/ppc/pmac.c
===================================================================
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -1587,6 +1587,8 @@ pmac_ide_dma_check(ide_drive_t *drive)
if (ide_tune_dma(drive))
return 0;
+ ide_set_max_pio(drive);
+
return -1;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 10/11] ide-pmac: add PIO autotune fallback to ->ide_dma_check
2007-08-04 20:12 [PATCH 10/11] ide-pmac: add PIO autotune fallback to ->ide_dma_check Bartlomiej Zolnierkiewicz
@ 2007-08-06 16:43 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2007-08-06 16:43 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, Benjamin Herrenschmidt
Bartlomiej Zolnierkiewicz wrote:
> Since ide-pmac allows separate PIO and DMA timings, and ide-pmac always sets
> ->autotune this change shouldn't have any other effect than bringing ide-pmac
> driver in-line with other host drivers wrt ->ide_dma_check implementation.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-06 16:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-04 20:12 [PATCH 10/11] ide-pmac: add PIO autotune fallback to ->ide_dma_check Bartlomiej Zolnierkiewicz
2007-08-06 16:43 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).