From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 11/11] ide: remove ->ide_dma_check
Date: Mon, 6 Aug 2007 20:14:43 +0200 [thread overview]
Message-ID: <200708062014.43106.bzolnier@gmail.com> (raw)
In-Reply-To: <46B7390E.5070408@ru.mvista.com>
On Monday 06 August 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > Index: b/drivers/ide/arm/icside.c
> > ===================================================================
> > --- a/drivers/ide/arm/icside.c
> > +++ b/drivers/ide/arm/icside.c
> > @@ -309,14 +309,6 @@ static int icside_dma_on(ide_drive_t *dr
> > return 0;
> > }
> >
> > -static int icside_dma_check(ide_drive_t *drive)
> > -{
> > - if (ide_tune_dma(drive))
> > - return 0;
> > -
> > - return -1;
> > -}
> > -
> > static int icside_dma_end(ide_drive_t *drive)
> > {
> > ide_hwif_t *hwif = HWIF(drive);
>
> Hm, looks like there's going to be some functionality change for this
> driver -- it didn't fallback to PIO before this patch... ;-)
It won't because this driver lacks ->set_pio_mode method... :-)
Bart
prev parent reply other threads:[~2007-08-07 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-04 20:13 [PATCH 11/11] ide: remove ->ide_dma_check Bartlomiej Zolnierkiewicz
2007-08-06 15:06 ` Sergei Shtylyov
2007-08-06 18:14 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708062014.43106.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).