From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]
Date: Fri, 10 Aug 2007 01:45:38 +0200 [thread overview]
Message-ID: <200708100145.38739.bzolnier@gmail.com> (raw)
In-Reply-To: <20070809235455.3117d5dc@the-village.bc.nu>
On Friday 10 August 2007, Alan Cox wrote:
> On Thu, 9 Aug 2007 23:19:34 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> >
> > Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4)
> > and for AEC6880[R] it is UDMA6 (not UDMA5):
> >
> > * Fix the problem by adding missing struct ata_port_info to artop_init_one().
> >
> > * Use the right naming (s/626/628/).
> >
> > * Bump driver version.
> >
> > Fixes IDE->libata regression, problem was never present in IDE aec62xx driver.
>
> Have you tested this ??
-ENODEV so no and testing is welcomed.
However I went over both drivers to make sure that this change is safe
and correct.
BTW presence of the above bugs would strongly indicate that pata_artop has
never been tested (properly) with AEC6x80[R], otherwise these bugs should
have been noticed and fixed much earlier.
Thanks,
Bart
next prev parent reply other threads:[~2007-08-09 23:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 21:19 [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R] Bartlomiej Zolnierkiewicz
2007-08-09 22:54 ` Alan Cox
2007-08-09 23:45 ` Bartlomiej Zolnierkiewicz [this message]
2007-08-10 14:01 ` Alan Cox
2007-08-10 14:02 ` Alan Cox
2007-08-15 8:17 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2007-08-10 14:38 Mikael Pettersson
2007-08-10 17:33 ` Alan Cox
2007-08-12 11:53 Mikael Pettersson
2007-08-13 13:30 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708100145.38739.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).