From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: rah@bash.sh, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards
Date: Sat, 11 Aug 2007 20:03:35 +0200 [thread overview]
Message-ID: <200708112003.35489.bzolnier@gmail.com> (raw)
In-Reply-To: <46BDF1A4.2020902@ru.mvista.com>
On Saturday 11 August 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> >>Index: linux-2.6/drivers/ide/pci/hpt366.c
> >>===================================================================
> >>--- linux-2.6.orig/drivers/ide/pci/hpt366.c
> >>+++ linux-2.6/drivers/ide/pci/hpt366.c
> [...]
> >>+ case HPT372 :
> >>+ case HPT372A:
> >>+ case HPT372N:
> >>+ case HPT374 :
> >>+ /*
> >>+ * Check for SATA drive by verifying that the word 93 is 0 and
> >>+ * the drive is ATA-5 or higher compatible.
> >>+ */
> >>+ if (id->hw_config == 0 && (id->major_rev_num & 0x7fe0))
>
> > Same check as in ide-iops.c::eighty_ninty_three().
>
> > Would make sense to add ide_id_is_sata_dev() inline to <linux/ide.h>.
>
> Right in this patch, or a later cleanup?
I prefer doing it in this patch but later cleanup is also OK...
Thanks.
Bart
next prev parent reply other threads:[~2007-08-11 18:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 20:08 [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards Sergei Shtylyov
2007-08-08 22:08 ` Bartlomiej Zolnierkiewicz
2007-08-10 18:12 ` Sergei Shtylyov
2007-08-10 21:16 ` Bartlomiej Zolnierkiewicz
2007-08-11 15:45 ` Sergei Shtylyov
2007-08-11 16:30 ` Bartlomiej Zolnierkiewicz
2007-08-11 18:59 ` Sergei Shtylyov
2007-08-18 19:18 ` Bartlomiej Zolnierkiewicz
2007-08-19 14:21 ` Sergei Shtylyov
2007-08-25 20:49 ` Sergei Shtylyov
2007-08-11 17:28 ` Sergei Shtylyov
2007-08-11 18:03 ` Bartlomiej Zolnierkiewicz [this message]
2007-08-11 19:23 ` Sergei Shtylyov
2007-08-25 17:13 ` Sergei Shtylyov
[not found] ` <200708271922.35546.bzolnier@gmail.com>
2007-09-01 14:36 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708112003.35489.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=rah@bash.sh \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).