Re: 2.6.23-rc3-mm1

Re: 2.6.23-rc3-mm1

[Torsten Kaiser]

On 8/22/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc3/2.6.23-rc3-mm1/
[snip]
> -ata-add-the-sw-ncq-support-to-sata_nv-for-mcp51-mcp55-mcp61.patch
> -ata-add-the-sw-ncq-support-to-sata_nv-for-mcp51-mcp55-mcp61-fix.patch
[snip]
>  Merged into mainline or a subsystem tree

That patch is no longer in 2.6.23-rc3-mm1, my bootlog says:
[    0.000000] Unknown boot option `sata_nv.swncq=1': ignoring

I could not find this patch in any git trees I looked and its removal
mail from mm-commit said:
"This patch was dropped because Changes in Jeff's tree destroyed it."


I only found out about the swncq=1 command line option yesterday and
so tested it only one day.
But I did not have any trouble with it, even as my drive was made by Maxtor.

The chipset:
00:05.0 IDE interface: nVidia Corporation MCP55 SATA Controller (rev a3)
00:05.1 IDE interface: nVidia Corporation MCP55 SATA Controller (rev a3)
00:05.2 IDE interface: nVidia Corporation MCP55 SATA Controller (rev a3)

The drive:
Device Model:     MAXTOR STM3320820AS
Serial Number:    5QF2E698
Firmware Version: 3.AAE

As it worked for me, I hope that patch will be picked up by someone. :)

Torsten

Re: 2.6.23-rc3-mm1

[Andrew Morton]

On Wed, 22 Aug 2007 19:24:39 +0200
"Torsten Kaiser" <just.for.lkml@googlemail.com> wrote:

> On 8/22/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc3/2.6.23-rc3-mm1/
> [snip]
> > -ata-add-the-sw-ncq-support-to-sata_nv-for-mcp51-mcp55-mcp61.patch
> > -ata-add-the-sw-ncq-support-to-sata_nv-for-mcp51-mcp55-mcp61-fix.patch
> [snip]
> >  Merged into mainline or a subsystem tree
> 
> That patch is no longer in 2.6.23-rc3-mm1, my bootlog says:
> [    0.000000] Unknown boot option `sata_nv.swncq=1': ignoring
> 
> I could not find this patch in any git trees I looked and its removal
> mail from mm-commit said:
> "This patch was dropped because Changes in Jeff's tree destroyed it."
> 
> 
> I only found out about the swncq=1 command line option yesterday and
> so tested it only one day.
> But I did not have any trouble with it, even as my drive was made by Maxtor.
> 
> The chipset:
> 00:05.0 IDE interface: nVidia Corporation MCP55 SATA Controller (rev a3)
> 00:05.1 IDE interface: nVidia Corporation MCP55 SATA Controller (rev a3)
> 00:05.2 IDE interface: nVidia Corporation MCP55 SATA Controller (rev a3)
> 
> The drive:
> Device Model:     MAXTOR STM3320820AS
> Serial Number:    5QF2E698
> Firmware Version: 3.AAE
> 
> As it worked for me, I hope that patch will be picked up by someone. :)
> 

This is a fairly regular occurrence in ata land: patches from maintainers
don't get merged, so I merge them for testing, then some fairly pointless
cleanup-style patch goes on a great tree-wide rampage thus destabilising or
simply destroying the more important, mysteriously-not-merged patch.

Nobody knows why this happens.

Peer and Kuan: can you please redo that patch against the current ata
development tree?

Thanks.

[-mm patch] unexport noautodma

[Adrian Bunk]

On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.23-rc2-mm2:
>...
> +ide-ide-remove-hwif-autodma-and-drive-autodma.patch
>...
>  IDE tree updates
>...

noautodma can now be unexported.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
957dc7601c050cb14a7afc842db0c2d62aaf3509 
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index b3b5f00..5b09066 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -100,8 +100,6 @@ static int ide_scan_direction; /* THIS was formerly 2.2.x pci=reverse */
 
 int noautodma = 0;
 
-EXPORT_SYMBOL(noautodma);
-
 #ifdef CONFIG_BLK_DEV_IDEACPI
 int ide_noacpi = 0;
 int ide_noacpitfs = 1;