Re: [PATCH] hook ACPI _PSx method to IDE power on/off

[Len Brown <lenb@kernel.org>]

On Saturday 04 August 2007 15:55, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 02 August 2007, Shaohua Li wrote:
> > ACPI spec defines the sequence of IDE power on/off:
> > Powering down:
> > 	Call _GTM.
> > 	Power down drive (calls _PS3 method and turns off power planes).
> > Powering up:
> > 	Power up drive (calls _PS0 method if present and turns on power planes).
> > 	Call _STM passing info from _GTM (possibly modified), with ID data from
> > 	each drive.
> > 	Initialize the channel.
> > 	May modify the results of _GTF.
> > 	For each drive:
> > 		Call _GTF.
> > 		Execute task file (possibly modified).
> > This patch adds the missed _PS0/_PS3 methods call.
> > 
> > Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> 
> applied, thanks
> 
> Len, are you OK with the ACPI part of the patch (below)?

yes.
Acked-by: Len Brown <len.brown@intel.com>

thanks,
-Len

> > Index: linux/drivers/acpi/bus.c
> > ===================================================================
> > --- linux.orig/drivers/acpi/bus.c	2007-08-02 13:35:06.000000000 +0800
> > +++ linux/drivers/acpi/bus.c	2007-08-02 13:56:56.000000000 +0800
> > @@ -262,10 +262,12 @@ int acpi_bus_set_power(acpi_handle handl
> >  		printk(KERN_WARNING PREFIX
> >  			      "Transitioning device [%s] to D%d\n",
> >  			      device->pnp.bus_id, state);
> > -	else
> > +	else {
> > +		device->power.state = state;
> >  		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
> >  				  "Device [%s] transitioned to D%d\n",
> >  				  device->pnp.bus_id, state));
> > +	}
> >  
> >  	return result;
> >  }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>