From: Brandon Philips <brandon@ifup.org>
To: postfail@hushmail.com
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH resubmit] /drivers/ata ioremap returncode check
Date: Wed, 22 Aug 2007 22:34:58 -0700 [thread overview]
Message-ID: <20070823053458.GA4418@ifup.org> (raw)
In-Reply-To: <159327.52462.qm@web44910.mail.sp1.yahoo.com>
On 19:47 Wed 22 Aug 2007, Scott Thompson wrote:
> Patchset against 2.6.23-rc3. corrects missing ioremap return
> checks, resending after making changes suggested....
>
> Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
> ------------------------------------------------------------
> diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
> index 4ca7fd6..8dc7c3b 100644
> --- a/drivers/ata/pata_ixp4xx_cf.c
> +++ b/drivers/ata/pata_ixp4xx_cf.c
> @@ -189,6 +189,10 @@ static __devinit int ixp4xx_pata_probe(struct platform_device *pdev)
> data->cs0 = devm_ioremap(&pdev->dev, cs0->start, 0x1000);
> data->cs1 = devm_ioremap(&pdev->dev, cs1->start, 0x1000);
>
> + if (!data->cs0 || !data->cs1) {
> + return -ENOMEM;
> + }
> +
You aren't following the Kernel CodingStyle there.
See Documentation/CodingStyle:
"Do not unnecessarily use braces where a single statement will do."
+ if (!data->cs0 || !data->cs1)
+ return -ENOMEM;
Thanks,
Brandon
next prev parent reply other threads:[~2007-08-23 5:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070823023328.19E6CDA82B@mailserver7.hushmail.com>
2007-08-23 2:47 ` [PATCH resubmit] /drivers/ata ioremap returncode check Scott Thompson
2007-08-23 5:34 ` Brandon Philips [this message]
2007-08-23 17:42 ` Alexey Dobriyan
2007-08-23 17:53 ` Brandon Philips
2007-08-23 19:34 Scott Thompson
2007-09-03 8:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823053458.GA4418@ifup.org \
--to=brandon@ifup.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=postfail@hushmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).