From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards Date: Mon, 3 Sep 2007 20:50:32 +0200 Message-ID: <200709032050.32397.bzolnier@gmail.com> References: <200709030019.22732.sshtylyov@ru.mvista.com> <46DB1C50.2020205@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ug-out-1314.google.com ([66.249.92.170]:43250 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753891AbXICSuc (ORCPT ); Mon, 3 Sep 2007 14:50:32 -0400 Received: by ug-out-1314.google.com with SMTP id z38so147485ugc for ; Mon, 03 Sep 2007 11:50:30 -0700 (PDT) In-Reply-To: <46DB1C50.2020205@ru.mvista.com> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Sunday 02 September 2007, Sergei Shtylyov wrote: > Hello, I wrote: > > The patch was 4/4 of course. :-< > Probably I was too esctatic about the code. ;-) > > > The Marvell bridge chips used on HighPoint SATA cards do not seem to support > > the MWDMA modes (at least that caould be seen in their so-called drivers :-), > > so the driver needs to account for this -- to achieve this: > > > - add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz > > with his consent, also adding the method callout to ide_rate_filter(); > > > - installed the method for all chips to only return empty mask if a SATA drive > > is detected onHPT372{AN]/374 chips... > > > Signed-off-by: Sergei Shtylyov > > > --- > > This patch against the current Linus' tree and unfortunately I was able to only > > compile test it since that tree gives MODPOST warning and dies early on bootup. > > Will hopefully try to test if/when I have time... :-) > > > Index: linux-2.6/drivers/ide/pci/hpt366.c > > =================================================================== > > --- linux-2.6.orig/drivers/ide/pci/hpt366.c > > +++ linux-2.6/drivers/ide/pci/hpt366.c > > @@ -1,5 +1,5 @@ > > /* > > - * linux/drivers/ide/pci/hpt366.c Version 1.12 Aug 25, 2007 > > + * linux/drivers/ide/pci/hpt366.c Version 1.13 Aug 22, 2007 > > Errr... and version shuold Aug 02 -- thought I've fixed that. :-/ and we have ATA_MWDMA2 define in _vanilla_ kernel now :) Bart