From: Jens Axboe <jens.axboe@oracle.com>
To: "Halevy, Benny" <bhalevy@panasas.com>
Cc: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, mike.miller@hp.com,
grant.likely@secretlab.ca, "Harrosh, Boaz" <bharrosh@panasas.com>,
dm-devel@redhat.com, j-nomura@ce.jp.nec.com
Subject: Re: [PATCH 6/7] blk_end_request: remove/unexport end_that_request_*
Date: Tue, 4 Sep 2007 23:24:35 +0200 [thread overview]
Message-ID: <20070904212435.GG4117@kernel.dk> (raw)
In-Reply-To: <E472128B1EB43941B4E7FB268020C89B02992D9B@riverside.int.panasas.com>
On Tue, Sep 04 2007, Halevy, Benny wrote:
> Boaz raised my attention to this patchset today...
> We suspect we'll still need the extern entry points for handling the bidi
> request in the scsi_io_completion() path as we only want to call
> end_that_request_chunk on req->next_rq and never
> end_that_request_last.
>
> (see
> http://www.bhalevy.com/open-osd/download/linux-2.6.23-rc2_and_iscsi-iscsi-2007_08_09/0005-SCSI-bidi-support.patch)
>
> If this is ok with you I'd leave these entry points in place rather than
> taking them out and putting them back in later.
There's no point in leaving them in when nothing current needs it, I'd
much rather add it back in should the need arise. That's the proper way
to handle things like this.
--
Jens Axboe
next prev parent reply other threads:[~2007-09-04 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 22:43 [PATCH 6/7] blk_end_request: remove/unexport end_that_request_* Kiyoshi Ueda
2007-09-04 21:25 ` Halevy, Benny
2007-09-04 21:24 ` Jens Axboe [this message]
2007-09-04 23:13 ` Kiyoshi Ueda
2007-09-05 7:36 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070904212435.GG4117@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=dm-devel@redhat.com \
--cc=grant.likely@secretlab.ca \
--cc=j-nomura@ce.jp.nec.com \
--cc=k-ueda@ct.jp.nec.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).