From: Matthew Wilcox <matthew@wil.cx>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Remove sync waiting code from libata
Date: Sat, 8 Sep 2007 11:17:31 -0600 [thread overview]
Message-ID: <20070908171731.GB6809@parisc-linux.org> (raw)
In-Reply-To: <46E259DD.5090609@gmail.com>
On Sat, Sep 08, 2007 at 05:14:21PM +0900, Tejun Heo wrote:
> Matthew Wilcox wrote:
> > By using the scsi async probing code, we can remove the 'sync' argument
> > from ata_scsi_scan_host():
>
> Hmmm... How so? @sync is there to keep device numbering stable even
> when SCSI scan fails due to allocation failure. I don't see how async
> probing changes that.
async probing also keeps device numbering stable. As long as the device
responds within ten seconds (and the current code has half a second as
the timeout), it'll get the same number it would have had, even though
other hosts have successfully completed their probes during that time.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-09-08 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 2:46 [PATCH] Remove sync waiting code from libata Matthew Wilcox
2007-09-08 8:14 ` Tejun Heo
2007-09-08 17:17 ` Matthew Wilcox [this message]
2007-09-08 17:36 ` Tejun Heo
2007-09-08 18:47 ` Alan Cox
2007-09-08 20:33 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070908171731.GB6809@parisc-linux.org \
--to=matthew@wil.cx \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).