linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <jens.axboe@oracle.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: [-mm patch] remove ide_get_error_location()
Date: Sun, 9 Sep 2007 22:24:55 +0200	[thread overview]
Message-ID: <20070909202455.GM3563@stusta.de> (raw)
In-Reply-To: <20070831215822.26e1432b.akpm@linux-foundation.org>

On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.23-rc3-mm1:
>...
>  git-block.patch
>...
>  git trees
>...

ide_get_error_location() is no longer used.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/ide/ide-io.c |   35 -----------------------------------
 include/linux/ide.h  |    5 -----
 2 files changed, 40 deletions(-)

924249789a0c0d577c5c5bfa91f4e514b7ebde60 
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index c1692d9..ec835e3 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -322,41 +322,6 @@ static void ide_complete_pm_request (ide_drive_t *drive, struct request *rq)
 	spin_unlock_irqrestore(&ide_lock, flags);
 }
 
-/*
- * FIXME: probably move this somewhere else, name is bad too :)
- */
-u64 ide_get_error_location(ide_drive_t *drive, char *args)
-{
-	u32 high, low;
-	u8 hcyl, lcyl, sect;
-	u64 sector;
-
-	high = 0;
-	hcyl = args[5];
-	lcyl = args[4];
-	sect = args[3];
-
-	if (ide_id_has_flush_cache_ext(drive->id)) {
-		low = (hcyl << 16) | (lcyl << 8) | sect;
-		HWIF(drive)->OUTB(drive->ctl|0x80, IDE_CONTROL_REG);
-		high = ide_read_24(drive);
-	} else {
-		u8 cur = HWIF(drive)->INB(IDE_SELECT_REG);
-		if (cur & 0x40) {
-			high = cur & 0xf;
-			low = (hcyl << 16) | (lcyl << 8) | sect;
-		} else {
-			low = hcyl * drive->head * drive->sect;
-			low += lcyl * drive->sect;
-			low += sect - 1;
-		}
-	}
-
-	sector = ((u64) high << 24) | low;
-	return sector;
-}
-EXPORT_SYMBOL(ide_get_error_location);
-
 /**
  *	ide_end_drive_cmd	-	end an explicit drive command
  *	@drive: command 
diff --git a/include/linux/ide.h b/include/linux/ide.h
index 48871f9..65de5c3 100644
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -1088,11 +1088,6 @@ extern ide_startstop_t ide_do_reset (ide_drive_t *);
 extern void ide_init_drive_cmd (struct request *rq);
 
 /*
- * this function returns error location sector offset in case of a write error
- */
-extern u64 ide_get_error_location(ide_drive_t *, char *);
-
-/*
  * "action" parameter type for ide_do_drive_cmd() below.
  */
 typedef enum {


  parent reply	other threads:[~2007-09-09 20:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070831215822.26e1432b.akpm@linux-foundation.org>
     [not found] ` <64bb37e0709010907x5a73f9dbof8e5b2c92425452e@mail.gmail.com>
2007-09-01 16:16   ` 2.6.23-rc4-mm1 Andrew Morton
2007-09-09 20:24 ` Adrian Bunk [this message]
2007-09-11 21:27   ` [-mm patch] remove ide_get_error_location() Bartlomiej Zolnierkiewicz
2007-09-12  5:54     ` Jens Axboe
     [not found] ` <20070910174926.GC30335@shadowen.org>
     [not found]   ` <20070910111926.9c942358.akpm@linux-foundation.org>
     [not found]     ` <64bb37e0709101159v47f586aby7f078ef1db5cbc39@mail.gmail.com>
2007-09-10 19:20       ` 2.6.23-rc4-mm1 Andrew Morton
2007-09-10 19:38         ` 2.6.23-rc4-mm1 Torsten Kaiser
2007-09-10 19:42         ` 2.6.23-rc4-mm1 FUJITA Tomonori
2007-09-10 20:43           ` 2.6.23-rc4-mm1 Torsten Kaiser
2007-09-11  8:32             ` 2.6.23-rc4-mm1 Jens Axboe
     [not found]     ` <20070910044323T.tomof@acm.org>
     [not found]       ` <20070914081018.GA20042@shadowen.org>
     [not found]         ` <64bb37e0709140601te21f5d0l9871ea03dbf4b135@mail.gmail.com>
2007-09-14 20:15           ` 2.6.23-rc4-mm1 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070909202455.GM3563@stusta.de \
    --to=bunk@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bzolnier@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).