* [PATCH 1/10] cmd64x: always set hwif->chipset for CMD646
@ 2007-09-11 21:35 Bartlomiej Zolnierkiewicz
2007-09-15 16:54 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-09-11 21:35 UTC (permalink / raw)
To: linux-ide
hwif->chipset should be set to ide_cmd646 also when DMA base is invalid.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/pci/cmd64x.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: b/drivers/ide/pci/cmd64x.c
===================================================================
--- a/drivers/ide/pci/cmd64x.c
+++ b/drivers/ide/pci/cmd64x.c
@@ -506,6 +506,9 @@ static void __devinit init_hwif_cmd64x(i
hwif->set_pio_mode = &cmd64x_set_pio_mode;
hwif->set_dma_mode = &cmd64x_set_dma_mode;
+ if (dev->device == PCI_DEVICE_ID_CMD_646)
+ hwif->chipset = ide_cmd646;
+
if (!hwif->dma_base)
return;
@@ -535,7 +538,6 @@ static void __devinit init_hwif_cmd64x(i
hwif->ide_dma_test_irq = &cmd648_ide_dma_test_irq;
break;
case PCI_DEVICE_ID_CMD_646:
- hwif->chipset = ide_cmd646;
if (dev->revision == 0x01) {
hwif->ide_dma_end = &cmd646_1_ide_dma_end;
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/10] cmd64x: always set hwif->chipset for CMD646
2007-09-11 21:35 [PATCH 1/10] cmd64x: always set hwif->chipset for CMD646 Bartlomiej Zolnierkiewicz
@ 2007-09-15 16:54 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2007-09-15 16:54 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> hwif->chipset should be set to ide_cmd646 also when DMA base is invalid.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-15 16:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-11 21:35 [PATCH 1/10] cmd64x: always set hwif->chipset for CMD646 Bartlomiej Zolnierkiewicz
2007-09-15 16:54 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).