From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
ak@suse.de, Greg KH <greg@kroah.com>,
len.brown@intel.com, linux-ide@vger.kernel.org, dz@debian.org,
minyard@acm.org, j.w.r.degoede@hhs.nl, lm-sensors@lm-sensors.org,
rlove@rlove.org, dmitry.torokhov@gmail.com, mzxreary@0pointer.de,
stelian@popies.net, ibm-acpi@hmh.eng.br, ambx1@neo.rr.com,
gimli@dark-green.com
Subject: Re: [PATCH] drivers/firmware: const-ify DMI API and internals
Date: Tue, 11 Sep 2007 23:54:41 +0200 [thread overview]
Message-ID: <200709112354.41774.bzolnier@gmail.com> (raw)
In-Reply-To: <20070901142719.GA31990@havoc.gtf.org>
On Saturday 01 September 2007, Jeff Garzik wrote:
>
> commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4
> Author: Jeff Garzik <jeff@garzik.org>
> Date: Sat Sep 1 10:16:45 2007 -0400
>
> drivers/firmware: const-ify DMI API and internals
>
> Three main sets of changes:
>
> 1) dmi_get_system_info() return value should have been marked const,
> since callers should not be changing that data.
>
> 2) const-ify DMI internals, since DMI firmware tables should,
> whenever possible, be marked const to ensure we never ever write to
> that data area.
>
> 3) const-ify DMI API, to enable marking tables const where possible
> in low-level drivers.
>
> And if we're really lucky, this might enable some additional
> optimizations on the part of the compiler.
>
> The bulk of the changes are #2 and #3, which are interrelated. #1 could
> have been a separate patch, but it was so small compared to the others,
> it was easier to roll it into this changeset.
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
[ a bit late ]
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
prev parent reply other threads:[~2007-09-11 21:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 14:27 [PATCH] drivers/firmware: const-ify DMI API and internals Jeff Garzik
2007-09-01 15:36 ` Greg KH
2007-09-01 16:01 ` Jeff Garzik
2007-09-09 17:51 ` Greg KH
2007-09-09 20:24 ` Sam Ravnborg
2007-09-09 21:12 ` Greg KH
2007-09-01 16:33 ` Andi Kleen
2007-09-01 21:21 ` Satyam Sharma
2007-09-02 17:17 ` [lm-sensors] " Jean Delvare
2007-09-11 21:54 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709112354.41774.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ambx1@neo.rr.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dz@debian.org \
--cc=gimli@dark-green.com \
--cc=greg@kroah.com \
--cc=ibm-acpi@hmh.eng.br \
--cc=j.w.r.degoede@hhs.nl \
--cc=jeff@garzik.org \
--cc=len.brown@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=minyard@acm.org \
--cc=mzxreary@0pointer.de \
--cc=rlove@rlove.org \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).