From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] drivers/firmware: const-ify DMI API and internals Date: Tue, 11 Sep 2007 23:54:41 +0200 Message-ID: <200709112354.41774.bzolnier@gmail.com> References: <20070901142719.GA31990@havoc.gtf.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ug-out-1314.google.com ([66.249.92.168]:43612 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934027AbXIKVwz (ORCPT ); Tue, 11 Sep 2007 17:52:55 -0400 Received: by ug-out-1314.google.com with SMTP id z38so139799ugc for ; Tue, 11 Sep 2007 14:52:53 -0700 (PDT) In-Reply-To: <20070901142719.GA31990@havoc.gtf.org> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: LKML , Andrew Morton , ak@suse.de, Greg KH , len.brown@intel.com, linux-ide@vger.kernel.org, dz@debian.org, minyard@acm.org, j.w.r.degoede@hhs.nl, lm-sensors@lm-sensors.org, rlove@rlove.org, dmitry.torokhov@gmail.com, mzxreary@0pointer.de, stelian@popies.net, ibm-acpi@hmh.eng.br, ambx1@neo.rr.com, gimli@dark-green.com On Saturday 01 September 2007, Jeff Garzik wrote: > > commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 > Author: Jeff Garzik > Date: Sat Sep 1 10:16:45 2007 -0400 > > drivers/firmware: const-ify DMI API and internals > > Three main sets of changes: > > 1) dmi_get_system_info() return value should have been marked const, > since callers should not be changing that data. > > 2) const-ify DMI internals, since DMI firmware tables should, > whenever possible, be marked const to ensure we never ever write to > that data area. > > 3) const-ify DMI API, to enable marking tables const where possible > in low-level drivers. > > And if we're really lucky, this might enable some additional > optimizations on the part of the compiler. > > The bulk of the changes are #2 and #3, which are interrelated. #1 could > have been a separate patch, but it was so small compared to the others, > it was easier to roll it into this changeset. > > Signed-off-by: Jeff Garzik [ a bit late ] Acked-by: Bartlomiej Zolnierkiewicz