From: Kyle McMartin <kyle@mcmartin.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-ide@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH] pata_ns87415: Initial cut at 87415/87560 IDE support
Date: Wed, 26 Sep 2007 19:35:31 -0400 [thread overview]
Message-ID: <20070926233531.GA22893@fattire.cabal.ca> (raw)
In-Reply-To: <20070926152731.718a5c74@the-village.bc.nu>
Just some quick review and build test on PARISC.
On Wed, Sep 26, 2007 at 03:27:31PM +0100, Alan Cox wrote:
> + tristate "Nat Semi NS87410 PATA support (Experimental)"
NS87415 shirley?
> + * pata_ns87415.c - NS87415 (non PARISC) PATA
> + * Test PARISC SuperIO
works fine. :)
> +static u8 ns87560_read_buggy(unsigned long port)
> +{
> + int retries = SUPERIO_IDE_MAX_RETRIES;
> + do {
> + tmp = ioread8(port);
> + if (tmp != 0)
> + return tmp;
> + udelay(50);
> + } while(retries-- > 0);
> + return tmp;
> +}
u8 tmp is undefined, and port should be void __iomem * if we're going to
use pci-iomap accessors.
Works good otherwise, I was able to mount and copy a cd. Patch attached.
Queued a patch to move SUPERIO_IDE_MAX_RETRIES to <asm/superio.h>.
Cheers,
Kyle
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 5a5e677..fb460a6 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -433,7 +433,7 @@ config PATA_NS87410
If unsure, say N.
config PATA_NS87415
- tristate "Nat Semi NS87410 PATA support (Experimental)"
+ tristate "Nat Semi NS87415 PATA support (Experimental)"
depends on PCI && EXPERIMENTAL
help
This option enables support for the National Semiconductor
diff --git a/drivers/ata/pata_ns87415.c b/drivers/ata/pata_ns87415.c
index 239628d..cfe4ef2 100644
--- a/drivers/ata/pata_ns87415.c
+++ b/drivers/ata/pata_ns87415.c
@@ -222,8 +222,9 @@ static int ns87415_check_atapi_dma(struct ata_queued_cmd *qc)
* Work around chipset problems in the 87560 SuperIO chip
*/
-static u8 ns87560_read_buggy(unsigned long port)
+static u8 ns87560_read_buggy(void __iomem *port)
{
+ u8 tmp;
int retries = SUPERIO_IDE_MAX_RETRIES;
do {
tmp = ioread8(port);
next prev parent reply other threads:[~2007-09-26 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 14:27 [PATCH] pata_ns87415: Initial cut at 87415/87560 IDE support Alan Cox
2007-09-26 23:35 ` Kyle McMartin [this message]
2007-09-29 6:35 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070926233531.GA22893@fattire.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).