Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

[Matthew Garrett <mjg59@srcf.ucam.org>]

On Thu, Sep 27, 2007 at 10:26:59AM -0700, Kristen Carlson Accardi wrote:

> 1.  How does it handle things when you have a bay that is located behind
> a dock and the dock ejects?  In the acpi bay driver, I use the mechanism
> that the dock driver exports to get undock notifications so that the bay
> can eject as well.

Hm. I'd been working on the assumption that ejecting the doc would 
trigger the bay notifications as well, but I've got no hardware here 
with those capabilities so it's kind of hard to check...

> 2.  What if someone wants to use their bay to charge their battery?  While
> I never bothered to implement this in acpi/bay.c, nothing ever prevented
> anyone from adding that support to the driver, where now it is prevented
> since this driver and another cannot coexist.

The spec seems to imply that even if the drive hotswap bay and the 
battery bay are physically the same, they're logically distinct. 10.2.1 
specifies that the battery bay should always be considered present, and 
that any insertion notification will be generated from the battery bay 
rather than the drive bay (so Notify (BAT1, 0x81) rather than Notify 
(_SB.MISC.OTHR.BONG.PRIM.SLAV, 0x81)). My code will only grab the 
latter notification, not the former.

I /suspect/ that _STA on the bay device won't return true if there's a 
battery in there, and so we aren't expected to call the _EJ0 method if 
the user wants to remove a battery. But I'm also lacking hardware to 
test this one, so it's possible that I'm utterly wrong :)

-- 
Matthew Garrett | mjg59@srcf.ucam.org