* [PATCH 9/15] cs5530: remove needless ide_lock taking
@ 2007-10-01 21:37 Bartlomiej Zolnierkiewicz
2007-10-02 13:00 ` Sergei Shtylyov
2007-10-02 13:45 ` Alan Cox
0 siblings, 2 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-10-01 21:37 UTC (permalink / raw)
To: linux-ide
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/pci/cs5530.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
Index: b/drivers/ide/pci/cs5530.c
===================================================================
--- a/drivers/ide/pci/cs5530.c
+++ b/drivers/ide/pci/cs5530.c
@@ -1,5 +1,5 @@
/*
- * linux/drivers/ide/pci/cs5530.c Version 0.76 Aug 3 2007
+ * linux/drivers/ide/pci/cs5530.c Version 0.77 Sep 24 2007
*
* Copyright (C) 2000 Andre Hedrick <andre@linux-ide.org>
* Copyright (C) 2000 Mark Lord <mlord@pobox.com>
@@ -146,7 +146,6 @@ static void cs5530_set_dma_mode(ide_driv
static unsigned int __devinit init_chipset_cs5530 (struct pci_dev *dev, const char *name)
{
struct pci_dev *master_0 = NULL, *cs5530_0 = NULL;
- unsigned long flags;
if (pci_resource_start(dev, 4) == 0)
return -EFAULT;
@@ -171,9 +170,6 @@ static unsigned int __devinit init_chips
goto out;
}
- spin_lock_irqsave(&ide_lock, flags);
- /* all CPUs (there should only be one CPU with this chipset) */
-
/*
* Enable BusMaster and MemoryWriteAndInvalidate for the cs5530:
* --> OR 0x14 into 16-bit PCI COMMAND reg of function 0 of the cs5530
@@ -224,8 +220,6 @@ static unsigned int __devinit init_chips
pci_write_config_byte(master_0, 0x42, 0x00);
pci_write_config_byte(master_0, 0x43, 0xc1);
- spin_unlock_irqrestore(&ide_lock, flags);
-
out:
pci_dev_put(master_0);
pci_dev_put(cs5530_0);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 9/15] cs5530: remove needless ide_lock taking
2007-10-01 21:37 [PATCH 9/15] cs5530: remove needless ide_lock taking Bartlomiej Zolnierkiewicz
@ 2007-10-02 13:00 ` Sergei Shtylyov
2007-10-02 13:45 ` Alan Cox
1 sibling, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2007-10-02 13:00 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
Bartlomiej Zolnierkiewicz wrote:
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 9/15] cs5530: remove needless ide_lock taking
2007-10-01 21:37 [PATCH 9/15] cs5530: remove needless ide_lock taking Bartlomiej Zolnierkiewicz
2007-10-02 13:00 ` Sergei Shtylyov
@ 2007-10-02 13:45 ` Alan Cox
2007-10-02 21:02 ` Bartlomiej Zolnierkiewicz
1 sibling, 1 reply; 5+ messages in thread
From: Alan Cox @ 2007-10-02 13:45 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
> - spin_lock_irqsave(&ide_lock, flags);
> - /* all CPUs (there should only be one CPU with this chipset) */
> -
NAK
What about pre-emptible kernels. Put in a private lock.
Alan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 9/15] cs5530: remove needless ide_lock taking
2007-10-02 13:45 ` Alan Cox
@ 2007-10-02 21:02 ` Bartlomiej Zolnierkiewicz
2007-10-03 0:14 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-10-02 21:02 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-ide
On Tuesday 02 October 2007, Alan Cox wrote:
> > - spin_lock_irqsave(&ide_lock, flags);
> > - /* all CPUs (there should only be one CPU with this chipset) */
> > -
>
> NAK
>
> What about pre-emptible kernels. Put in a private lock.
All the removed code resided in init_chipset_cs5530() which is called only
during the controller initialization. Moreover pata_cs5530 also don't have
any locking in cs5530_init_chip().
Bart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 9/15] cs5530: remove needless ide_lock taking
2007-10-02 21:02 ` Bartlomiej Zolnierkiewicz
@ 2007-10-03 0:14 ` Alan Cox
0 siblings, 0 replies; 5+ messages in thread
From: Alan Cox @ 2007-10-03 0:14 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide
> All the removed code resided in init_chipset_cs5530() which is called only
> during the controller initialization. Moreover pata_cs5530 also don't have
> any locking in cs5530_init_chip().
Fair enough, and I haven't found a reason for the locking being needed
from doc reviews (hence its not in libata).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-10-03 0:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-01 21:37 [PATCH 9/15] cs5530: remove needless ide_lock taking Bartlomiej Zolnierkiewicz
2007-10-02 13:00 ` Sergei Shtylyov
2007-10-02 13:45 ` Alan Cox
2007-10-02 21:02 ` Bartlomiej Zolnierkiewicz
2007-10-03 0:14 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).