* [PATCH] IDE: Remove inclusion of non-existent io_trace.h.
@ 2007-10-07 11:51 Robert P. J. Day
2007-10-08 20:38 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2007-10-07 11:51 UTC (permalink / raw)
To: linux-ide; +Cc: bzolnier, gadio
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
the fact that this header file doesn't exist has apparently been
known for quite some time:
http://osdir.com/ml/linux.tape/2005-07/msg00001.html
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 1fa5794..e5a86a9 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -621,7 +621,6 @@ typedef struct os_dat_s {
*/
#define USE_IOTRACE 0
#if USE_IOTRACE
-#include <linux/io_trace.h>
#define IO_IDETAPE_FIFO 500
#endif
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] IDE: Remove inclusion of non-existent io_trace.h.
2007-10-07 11:51 [PATCH] IDE: Remove inclusion of non-existent io_trace.h Robert P. J. Day
@ 2007-10-08 20:38 ` Bartlomiej Zolnierkiewicz
2007-10-19 21:29 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-10-08 20:38 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: linux-ide, gadio
Hi,
On Sunday 07 October 2007, Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> the fact that this header file doesn't exist has apparently been
> known for quite some time:
>
> http://osdir.com/ml/linux.tape/2005-07/msg00001.html
>
> diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
> index 1fa5794..e5a86a9 100644
> --- a/drivers/ide/ide-tape.c
> +++ b/drivers/ide/ide-tape.c
> @@ -621,7 +621,6 @@ typedef struct os_dat_s {
> */
> #define USE_IOTRACE 0
> #if USE_IOTRACE
> -#include <linux/io_trace.h>
> #define IO_IDETAPE_FIFO 500
> #endif
It seems that all code covered by #if/#endif USE_IOTRACE in ide-tape.c
could be removed as well. Care to respin the patch?
Thanks,
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IDE: Remove inclusion of non-existent io_trace.h.
2007-10-08 20:38 ` Bartlomiej Zolnierkiewicz
@ 2007-10-19 21:29 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-10-19 21:29 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: linux-ide, gadio
On Monday 08 October 2007, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Sunday 07 October 2007, Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
applied
> > ---
> >
> > the fact that this header file doesn't exist has apparently been
> > known for quite some time:
> >
> > http://osdir.com/ml/linux.tape/2005-07/msg00001.html
> >
> > diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
> > index 1fa5794..e5a86a9 100644
> > --- a/drivers/ide/ide-tape.c
> > +++ b/drivers/ide/ide-tape.c
> > @@ -621,7 +621,6 @@ typedef struct os_dat_s {
> > */
> > #define USE_IOTRACE 0
> > #if USE_IOTRACE
> > -#include <linux/io_trace.h>
> > #define IO_IDETAPE_FIFO 500
> > #endif
>
> It seems that all code covered by #if/#endif USE_IOTRACE in ide-tape.c
> could be removed as well. Care to respin the patch?
but the follow-up patch still would be nice :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-19 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-07 11:51 [PATCH] IDE: Remove inclusion of non-existent io_trace.h Robert P. J. Day
2007-10-08 20:38 ` Bartlomiej Zolnierkiewicz
2007-10-19 21:29 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).