linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bernd Schubert <bs@q-leap.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Re: sil3114 data corruption
Date: Thu, 11 Oct 2007 14:20:34 +0200	[thread overview]
Message-ID: <200710111420.35166.bs@q-leap.de> (raw)
In-Reply-To: <200710111415.35203.bs@q-leap.de>

This will add the sil3114 back to the controllers with the mod15 bug. Without 
this patch no workaround for this controller is done and people might/will 
suffer from data corruption.

Also rather trivial, though with a huge effect, the speed for the effected 
disks will go down from about 45-50MB/s to 20-25MB/s. But better safe than 
lost data or damaged filesystem.

Signed-off-by: Bernd Schubert <bs@q-leap.de>

Index: linux-2.6.23-rc9/drivers/ata/sata_sil.c
===================================================================
--- linux-2.6.23-rc9.orig/drivers/ata/sata_sil.c	2007-10-11 10:45:02.000000000 
+0200
+++ linux-2.6.23-rc9/drivers/ata/sata_sil.c	2007-10-11 10:45:08.000000000 
+0200
@@ -241,7 +241,8 @@ static const struct ata_port_info sil_po
 	},
 	/* sil_3114 */
 	{
-		.flags		= SIL_DFL_PORT_FLAGS | SIL_FLAG_RERR_ON_DMA_ACT,
+		.flags		= SIL_DFL_PORT_FLAGS | SIL_FLAG_RERR_ON_DMA_ACT
+				| SIL_FLAG_MOD15WRITE,
 		.pio_mask	= 0x1f,			/* pio0-4 */
 		.mwdma_mask	= 0x07,			/* mwdma0-2 */
 		.udma_mask	= ATA_UDMA5,



-- 
Bernd Schubert
Q-Leap Networks GmbH

  reply	other threads:[~2007-10-11 12:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 15:09 sil3114 data corruption Bernd Schubert
2007-10-10  9:12 ` Bernd Schubert
2007-10-11 12:09   ` [PATCHES] " Bernd Schubert
2007-10-11 12:15     ` [PATCH 1/3] " Bernd Schubert
2007-10-11 12:20       ` Bernd Schubert [this message]
2007-10-11 12:33     ` [PATCH 3/3] faster workaround Bernd Schubert
2007-10-11 13:26       ` Alan Cox
2007-10-11 14:19         ` Jeff Garzik
2007-10-11 14:39           ` Bernd Schubert
2007-10-11 15:04             ` Jeff Garzik
2007-10-11 15:18               ` Bernd Schubert
2007-10-12 21:08                 ` Jeff Garzik
2007-10-15 10:18                   ` Bernd Schubert
2007-10-11 14:50           ` Alan Cox
2007-10-11 14:59             ` Jeff Garzik
2007-10-23  8:08               ` Tejun Heo
2007-10-23 17:28                 ` Bernd Schubert
2007-10-24 13:39                 ` Soeren Sonnenburg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710111420.35166.bs@q-leap.de \
    --to=bs@q-leap.de \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).