From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Tony Battersby <tonyb@cybernetics.com>
Cc: linux-ide@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] ide: fix serverworks.c UDMA regression
Date: Tue, 16 Oct 2007 21:25:41 +0200 [thread overview]
Message-ID: <200710162125.41987.bzolnier@gmail.com> (raw)
In-Reply-To: <4713B9FA.8050803@cybernetics.com>
On Monday 15 October 2007, Tony Battersby wrote:
> The patch described by the following excerpt from ChangeLog-2.6.22 makes
> it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):
>
> commit 2d5eaa6dd744a641e75503232a01f52d0768884c
> Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Date: Thu May 10 00:01:08 2007 +0200
>
> ide: rework the code for selecting the best DMA transfer mode (v3)
>
> ...
>
> This one-line patch against 2.6.23 fixes the problem.
Thanks!! (and sorry for the bug)
> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
applied
Greg/Chris: this is a perfect candidate for 2.6.23.2
> ---
> --- linux-2.6.23/drivers/ide/pci/serverworks.c.orig 2007-10-15 12:15:01.000000000 -0400
> +++ linux-2.6.23/drivers/ide/pci/serverworks.c 2007-10-15 13:47:29.000000000 -0400
> @@ -97,6 +97,7 @@ static u8 svwks_udma_filter(ide_drive_t
> mode = 2;
>
> switch(mode) {
> + case 3: mask = 0x3f; break;
> case 2: mask = 0x1f; break;
> case 1: mask = 0x07; break;
> default: mask = 0x00; break;
next prev parent reply other threads:[~2007-10-16 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 19:05 [PATCH] ide: fix serverworks.c UDMA regression Tony Battersby
2007-10-16 19:25 ` Bartlomiej Zolnierkiewicz [this message]
2007-11-13 23:28 ` [stable] " Greg KH
2007-11-14 14:34 ` Tony Battersby
2007-11-14 16:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710162125.41987.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
--cc=tonyb@cybernetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).